Bug #16116: Accessibility error: input type="image" - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #16116

closed

Accessibility error: input type="image"

Added by Dmitry Pikhno over 18 years ago. Updated over 18 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Martin Kutschker

Category:

Content Rendering

Target version:

Start date:

2006-05-03

Due date:

% Done:

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

class.tslib_content.php :: function FORM

line 1857 - submit button generation

$image=$this->IMAGE($conf['image.']);
....
if($image)    {
$fieldCode = str_replace('<img','<input type="image"'.$addParams.' name="'.$confData['fieldname'].'"' ,$image);

it is completele wrong. "input" tag doesn't have height, width and border attributes.

(issue imported from #M3397)

Files

Download all files

tslib_content-submit.diff (2.04 KB) tslib_content-submit.diff		Administrator Admin, 2006-05-15 23:09
tslib_content-submit2.diff (3.81 KB) tslib_content-submit2.diff		Administrator Admin, 2006-06-28 16:11

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Karsten Dambekalns over 18 years ago

It would probably be better to use IMG_RESOURCE...

Actions

Copy link

Updated by Martin Kutschker over 18 years ago

Patch uses IMG_RESOURCE.

Actions

Copy link

Updated by Administrator Admin over 18 years ago

The patch gave me errors, so I had to change the code a bit :
case 'submit':
$value=trim($parts²);
if ($conf['image.']) {
$this->data[$this->currentValKey]=$value;
/*$image=$this->IMAGE;
} else $image='';
if($image) {
$fieldCode = str_replace('<img','<input type="image"'.$addParams.' name="'.$confData['fieldname'].'"' ,$image);
*/
$image=$this->IMG_RESOURCE($conf['image.']);
} else {
$image='';
}
if ($image) {
$fieldCode=sprintf('<input type="image" name="%s"'.$elementIdAttribute.' src="%s"'.$addParams.' />', $confData['fieldname'],$image);
} else {
$fieldCode=sprintf('<input type="submit" name="%s"'.$elementIdAttribute.' value="%s"'.$addParams.' />',
$confData['fieldname'], t3lib_div::deHSCentities(htmlspecialchars($value)));
}
break;