Project

General

Profile

Actions

Bug #16310

closed

FE editing - 'editforms on-page' - flag has no effect.

Added by Beat Zimmerli over 18 years ago. Updated over 18 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Communication
Target version:
-
Start date:
2006-07-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.0
PHP Version:
4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When in frontend editing mode, the setting of the 'editforms on-page'- flag has no longer any effect. That is, in order to edit a record typo3 opens in any case a new page.

(issue imported from #M3779)

Actions #1

Updated by Beat Zimmerli over 18 years ago

To correct the error replace line 7060 in typo3/sysext/cms/tslib/class.tslib_content.php with the following:
$eFONPage = $GLOBALS['BE_USER']->uc['TSFE_adminConfig']['edit_editFormsOnPage'] && $BE_USER->workspace==0; // Editing forms on page only supported in Live workspace (because of incomplete implementation)

The original line read: ...... $BE_USER->workspace===0; .........

Actions #2

Updated by Karsten Dambekalns over 18 years ago

In current TYPO3_4-0 it's line 7076, and the suggested fix did not work for me when using edit icons, only when using edit panels. But that may be the normal case - I did not really look at FE editing ever... :)

Actions #3

Updated by Martin Kutschker over 18 years ago

The fix is bogus.

The original line accesses $BE_USER instead of $GLOBALS['BE_USER'].

But this does not fix anything.

I could not make the form appear WITHIN the page. But it doesn't work for me in 3.8 either.

What is working is "no-popups". If you enable that then the form stays in the same browser window.

Actions #4

Updated by Martin Kutschker over 18 years ago

Ok, stupid me. I did click on the edit icons of the fields. It doesn work there. It is and was only on complete records.

I'll fix this in SVN - yeah we've moved :-)

Actions

Also available in: Atom PDF