Feature #16651

add showPermaLink config also via typoscript

Added by David Toshack over 13 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Should have
Category:
felogin
Target version:
-
Start date:
2006-10-18
Due date:
% Done:

0%

PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Ability to configure the showPermaLink boolean from typoscript

(issue imported from #M4403)

showPermaLoginConf.diff View (1.42 KB) Administrator Admin, 2006-10-28 22:48

History

#1 Updated by Mario Rimann over 13 years ago

I think you patch is ok. But there's one thing I don't understand:

The if clause contains a part like "($GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] 0 || $GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] 1)".

Could this be removed? Or what is it used for? (I know, it wasn't you that wrote this line of code, it was in there before your patch).

#2 Updated by Ingmar Schlecht over 13 years ago

Hi Mario,

this is the possible values of $TYPO3_CONF_VARS[FE][permalogin]:
-1: Permanent login for FE users disabled.
0: By default permalogin is disabled for FE users but can be enabled by a form control in the login form.
1: Permanent login is by default enabled but can be disabled by a form control in the login form.
2: Permanent login is foced to be enabled.

In any case, permanent login is only possible if TYPO3_CONF_VARS[FE][lifetime] lifetime is > 0.

Obviously is makes sense to only display the checkbox if the value of $TYPO3_CONF_VARS[FE][permalogin] is either 0 or 1.

#3 Updated by Ingmar Schlecht over 13 years ago

+1 for the patch.

#4 Updated by Mario Rimann over 13 years ago

Thanks Ingmar for clarification - got it now :-)

#5 Updated by Stefan Strasser over 13 years ago

There was a typo in the patch which made it ineffective. The if-clause asked for 'showPermalogin' instead of 'showPermaLogin' (as it was defined in ext_typoscript_setup.txt).

I've committed the corrected patch to svn, it will be in 3.0.2.

#6 Updated by Stefan Strasser over 12 years ago

newloginbox 3.1.0 released

Also available in: Atom PDF