Project

General

Profile

Actions

Bug #16795

closed

htmlArea RTE: Problem when cutting pasting links within table cells or list items

Added by Stefan van over 17 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2006-12-18
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If a table is created within a content element and within that table a link is created, cutting and pasting this link results in an unwanted side effect.

The cell containing the original link still contains the link, only this time only the URL and not the text. The target cell contains the original URL and link.

(issue imported from #M4670)


Files

beforeafter.jpg (262 KB) beforeafter.jpg Administrator Admin, 2006-12-18 09:48
0004670_htmlarea-1.8.3_TYPO3-4.3-beta2_svn-6273.patch (3.32 KB) 0004670_htmlarea-1.8.3_TYPO3-4.3-beta2_svn-6273.patch Administrator Admin, 2009-10-24 12:22
rtehtmlarea_bugfix_4670_trunk.patch (2.28 KB) rtehtmlarea_bugfix_4670_trunk.patch Administrator Admin, 2009-10-29 23:21
rtehtmlarea_bugfix_4670_trunk_v2.patch (2.6 KB) rtehtmlarea_bugfix_4670_trunk_v2.patch Administrator Admin, 2009-11-12 15:45
Actions #1

Updated by Stanislas Rolland about 15 years ago

I think the problem arises when the link is the only element within the cell and you select the text and cut it (with ctrl-x or the cut button), or backspace it. The link remains even if there is no more text. If you start to enter some text in the cell, you see the link again. I think the same issue could arise, for example, in lists of links.

If fact, if you have the unlink button in the tool bar, you will see that after cutting the text of the link, the unlink button is still available, indicating that the link is still there. If you press the unlink button, the link is gone.

I am not sure how this should be resolved. If the text in a cell is inside any inline element, such as bold or strong, etc., the same behaviour will be observed. The text is gone, but the empty inline element remains.

In short, cutting cuts the text not the html markup.

This behaviour is common to all browsers, except that in case of an empty link, IE will remove it!

Until this is resolved, the only safe way is to use unlink before or after removing the text.

Actions #2

Updated by Ralf Hettinger over 14 years ago

This turns out to be pretty inconvenient for editors.

Attached patch filters links without linktext on the way to database, since those links would not be visible at all in htmlarea.
Which is a change of behaviour as well and maybe should be configurable if applied... although I would think it rather is a bugfix :)

Actions #3

Updated by Staffan Ericsson over 14 years ago

@Ralf: Is the filter susch as <a href=""></a> is filtered out but not <a href=""><td></td></a>

And how does it work if it's <a href="" class="bogus"></a>? You can define a class so it shows something without any content in it?

Actions #4

Updated by Ralf Hettinger over 14 years ago

Hi Staffan,
currently my suggestion would filter both of your examples above.

Comment for example 1: I can see, that this probably would be no good if htmlarea is used for something like "RTE styling", which your example <a href=""><td></td></a> implies. Which supports the idea of having the behaviour of the filter configurable - maybe an option like: Only filter empty links if there is none of the following tags inside: [list of tags].

Comment for example 2: I tried that first. As from my experience, showing "empty" links by CSS styling won't work in IE: it just wouldn't apply the CSS style due to the display-property of links in htmlarea. Changing the display property of links in htmlarea has other nasty side-effects, therefore I'd say that this isn't the way to go.

Actions #5

Updated by Staffan Ericsson over 14 years ago

If example 1 was rewritten to <a href=""><img /></a>?

Example 2 was not related to the BE but to the frontend representation of links. But at the same time, a loss of an empty link element is not a major problem for me.

Actions #6

Updated by Ralf Hettinger over 14 years ago

Hi Staffan,

regarding example 2: I think I now understand the idea - you could then in frontend give such bogus links a display none or the like. I would however dislike that very much if it was thought that way.

Regarding example 1 - my suggestion ain't the way to go, thanks for pointing that out.
Since it's nearly impossible to judge, when to filter links and when not without knowing the use of htmlarea (and keeping in mind that this could mean undesired loss of information in worst case), there's the need for configuring this filtering; I will try to add this in the next couple of days.

Another idea would be to append a [&]nbsp; to the linktext if no text is found within the link tags. But this again would have possible undesired side-effects, why I'd think this is not a very good idea as well.

Actions #7

Updated by Stanislas Rolland over 14 years ago

The attached patch (rtehtmlarea_bugfix_4670_trunk.patch) cleans up any empty "a" tag left over by a cut operation (using CTRL-x key or Cut button), as well as other garbage that Safari may leave behind.

Tested in FF 3.5, IE8, Opera 10 and Safari 4.

Please test it. After installing the patch, it is necessary to clear the RTE Cache and the browser cache.

Actions #8

Updated by Stanislas Rolland over 14 years ago

Second version of patch applies to current trunk (revision 6404+).

Actions #9

Updated by Stanislas Rolland over 14 years ago

Committed to SVN TYPO3core trunk (revision 6406) for inclusion in TYPO3 4.3.

Actions #10

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF