TYPO3 Core

sry, i tested now with all browsers and had to correct a little. Please forget first patch and look to 2nd one.

sry, my tortoise did something wrong, patch 3 is now the actual !

I also changed the vHWin as Masi suggested, cause it's the better way to handle the object.

so param for newWindoObject is now:

typolink.JSWindow.windowVar = myWindowObject

Arghh - my tortoise ... forget last 5 lines with -, i never removed them ...

sry for confusing, this is the change i made:

if ($JSwindowParams) {
$wtarget=$conf['JSWindow.']['target']?$conf['JSWindow.']['target']:'FEopenLink';
$winObj = $conf['JSWindow.']['windowVar'] ? $conf['JSWindow.']['windowVar'] : 'vHWin_'.md5(rand());

// Create TARGET-attribute only if the right doctype is used
                if (!t3lib_div::inList('xhtml_strict,xhtml_11,xhtml_2', $GLOBALS['TSFE']->xhtmlDoctype))    {
                    $target = ' target="'.$wtarget.'"';
                } else {
                    $target = '';
                }

$onClick=$winObj."=window.open('".$GLOBALS['TSFE']->baseUrlWrap($finalTagParts['url'])."','$wtarget','".$JSwindowParams."');".$winObj.".focus();return false;";
                $res = '<a href="'.htmlspecialchars($finalTagParts['url']).'"'. $target .' onclick="'.htmlspecialchars($onClick).'"'.($title?' title="'.$title.'"':'').($linkClass?' class="'.$linkClass.'"':'').$finalTagParts['aTagParams'].'>';
            } else {
...

This is a nice patch... I think it could be improved a bit concerning links that are generated by RTE in the following situations:

Imagine multiple content elements on one page having some popuplinks. But the Popups have different sizes. If you click on one link, don't close the popup then open another one (of different size!) then the content will be put into the existing popup of wrong size.

My idea: hashing the target URL to get some unique JS window object name. Something like this:

$jsWindownName = $GLOBALS['TSFE']->config['config.']['uniquePopupWindowName'] ? md5($finalTagParts['url']) : 'FEopenLink';

$wtarget = $conf['JSWindow.']['target'] ? $conf['JSWindow.']['target'] : $jsWindowName;

What do you think?

corrected typo and made hash xhtml valid (starting always with jswin)

$jsWindowName = $GLOBALS['TSFE']->config['config']['uniquePopupWindowName'] ? 'jswin' . md5($finalTagParts['url']) : 'FEopenLink';
$wtarget = $conf['JSWindow.']['target'] ? $conf['JSWindow.']['target'] : $jsWindowName;
$winObj = $conf['JSWindow.']['windowVar'] ? $conf['JSWindow.']['windowVar'] : 'vHWin_'.md5(rand());

hmmm ... I don't really see the relation to #17968 ... two completely different issues, aren't they?

I think so either and have deleted that relation again (some weeks ago already).

Jochen, can you provide an updated version of this patch and post it to Core List?
Than this will finally get fixed!
See here http://typo3.org/teams/core/core-mailinglist-rules

@ Christopher:

Yes, I'll do that ... against which version(s) should I patch it?

Hey all - wouldn't this one still be worth a patch?

Hi Jochen,

sorry for the delay.

Please make the patch against trunk, which you find at https://svn.typo3.org/TYPO3v4/Core/trunk/ .
As this is a feature, this already is enough.

Then send a mail with your patch to Core List. You can find a how to here: http://typo3blogger.de/ab-in-den-core/ (I assume you're German ;)).

If you have any questions, don't hesitate to ask!

Hey Christopher,

me too, I completely forgot about this issue. So thanks for your quick answer now after the reminder and thanks especially for the blog post link - very useful!

I modified the code a bit and attached the new patch

4963_v1.patch

I have posted it to the core list.