Bug #17215

Port number in lockSSL redirect is not configurable

Added by Christopher Hlubek almost 14 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2007-04-17
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Shared hosting environments often have limited ip addresses and name based virtual hosting is not an option for HTTPS webs.

Securing multiple TYPO3 webs (e.g. BE access) with SSL in virtual hosting environments with limited ip addresses is only possible using different HTTPS ports.

But the lockSSL option itself does only a redirect from http://{$url} to https://{$url} , which doesn't allow to change the port during redirect.

It would be nice to add a feature to configure the port in a configuration option like ($TYPO3_CONF_VARS['BE']['lockSSLPort'] and to append / exchange it in the hostname part of the url.

(issue imported from #M5442)


Files

TYPO3-lockSSLPort.patch (2.28 KB) TYPO3-lockSSLPort.patch Administrator Admin, 2008-02-17 23:18
TYPO3-lockSSLPort-2.patch (2.35 KB) TYPO3-lockSSLPort-2.patch Administrator Admin, 2008-02-18 09:40
#1

Updated by Benni Mack almost 13 years ago

Hey Christopher,

can you provide a patch for this?

#2

Updated by Christopher Hlubek almost 13 years ago

Hi Benjamin,

I provided a patch with a quick fix for this issue. The code is straight forward and somehow duplicate.

#3

Updated by Benni Mack almost 13 years ago

Hey Christopher.

Looks quite good. But please don't do a (if ? then : else) over multiple lines. Either put in one line or do a
if () {
then
} else {
...
}

Otherwise, I think you can submit this one to the core list.
http://typo3.org/teams/core/core-mailinglist-rules/

#4

Updated by Christopher Hlubek almost 13 years ago

Hi Benjamin,

the short if statement is fixed in the 2nd patch. I will submit it to the core list today.

#5

Updated by Michael Stucki almost 13 years ago

Fixed in revision 3343.

Also available in: Atom PDF