TYPO3 Core

Added Patch, which fixes the check when no content is returned by t3lib_div::getURL and an error message is shown, with hints what can be checked. I removed the redirection with header(location: ..) because redirection can be done by setting pagenotfound_handling to 'REDIRECT:<url>'

You changed the check from FALSE to "\r\n". Isn't CURL supposed to return a boolean FALSE on error?

As for the action, too me it makes more sense to fall back to the standard TYPO3 error page and write the failure to the log (t3lib_div::sysLog)

You're right in that point, that t3lib_div::getURL returns false if an error occured fetching data from the URL (nothing to do with CURL, as this function decides whether to use CURL or not). But then the check must at least be changed to

if ($res === false)

because $res contains the return value of the function and $content is at least filled with "\r\n" directly before the if

$content.= "\r\n";

so $content will never be boolean!

For the error page:
I don't know what you mean, as my patch will change the behaviour from silently using a redirect, to showing the standard TYPO3 error page using the function $this->printError as it is done in the whole class tslib_fe.

Of course logging the failure would be nice, but then should be done by extending printError function.

Add revised patch

Commited to:

- trunk (rev. 2756) (for 4.2-alpha3)
- TYPO3_4-1 (rev. 2757) (for 4.1.4)