Project

General

Profile

Actions

Bug #18334

closed

class tslib_pibase still uses PHP4 variable declaration

Added by Franz Holzinger over 16 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2008-02-28
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The class tslib_pibase still uses var declarations. This is PHP4, but not PHP5. This class is used by every TYPO3 extension as the base. So why do you demand PHP5 for TYPO3 4.2 and the extensions which use PHP5 do not look the same?

In the extension I want to use full PHP5:
public $prefixId = 'tx_ttproducts_pi1'; // Same as class name
public $scriptRelPath = 'pi1/class.tx_ttproducts_pi1.php'; // Path to this script relative to the extension dir.
public $extKey = TT_PRODUCTS_EXTkey; // The extension key.

Or maybe protected would do the job.

But this does not look fine compared to tslib_pibase:

var $scriptRelPath; // Path to the plugin class script relative to extension directory, eg. 'pi1/class.tx_newfaq_pi1.php'
var $extKey; // Extension key.
var $piVars = Array ( // This is the incoming array by name $this->prefixId merged between POST and

IMHO this basic class should like like PHP5 and not PHP4.

(issue imported from #M7707)

Actions

Also available in: Atom PDF