Bug #18420
closedTransparent PNGs do not work in IE 6
0%
Description
We need a JS solution for this.
(issue imported from #M7817)
Files
Updated by Benni Mack over 16 years ago
I think this is a showstopper. Most of my editors use IE 6.
Updated by Ingo Renner over 16 years ago
Steffen and I have worked out a nearly perfect solution now, only the background of the tree filter is missing now...
Updated by Ingo Renner over 16 years ago
Steffen I attached what I got since yesterday as I don't know when I'll be online again today....
Updated by Oliver Hader over 16 years ago
The only possibility to do this is the "DXImageTransform.Microsoft.AlphaImageLoader" filter used as style in MSIE 5.5 and MSIE 6. I didn't test it, but would have done this similar.
A question concerning coding styles:
if(el.src.endsWith('.png')) { vs. (with spaces) if (el.src.endsWith('.png')) {
Personally I think that second version is better readable.
Updated by Moreno Feltscher over 16 years ago
What about supersleight which does exactly what we need: http://snipplr.com/view/4224/ie-6-transparent-png-fix--supersleight/
?
Updated by Steffen Kamper over 16 years ago
Hi Ingo,
i tested your last patch, and with toolbar it works. It doesn't with the filter and the left menu, they have png as background-image and this routine seems to fail, i will debug this and report as soon as i get results.
@olly - sure, formatting rules should be same as for php, but first we need a working solution ;-)
@moreno - thx for that link. I checked nearly all solutions i found and will compare the background-image-thing if our solution will fail.
Updated by Steffen Kamper over 16 years ago
I attached a new patch where i removed JS-Errors.
So now toolbar and filterbox are ok, but Menu arrows disappear after setStyle. maybe the background position is missing.
The problem was: Event matches window so search for any element matching the condition. $('filterbox') only matches in pagetree but not in other documents.
Calling pngHack with a div fails with src-method, so undefined-check has to be done.
... one step further ;-)
Updated by Ingo Renner over 16 years ago
@Moreno I've seen that but Steffen the came up with a nice prototype style solution
Updated by Moreno Feltscher over 16 years ago
Oh yes, I see. Keep going on! You're doing great work.
Is this one here a nowbrainer (because of the double ;;)?
+ var transparentGifPath = 'clear.gif';;
Updated by Ingo Renner over 16 years ago
Moreno, I tried supersleigh no, it's got the same issues as our solution and makes things even worse as it replaces even more images (even those we do not want to be replaced)
Updated by Steffen Kamper over 16 years ago
The problem is with background images - there are strange sideeffects (input not clickable, disappearing images etc) so Ingo's final solution is the best we can do, give IE6 a special stylesheet.
As we spent hours in this problem for now it's enough energy for such a crap browser, Ingo's fix works and that's it.