Project

General

Profile

Actions

Bug #18777

closed

Modified tslib_cObj::substituteMarkerArray() misses call parameter

Added by Francois Suter over 16 years ago. Updated about 16 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Communication
Target version:
-
Start date:
2008-05-13
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
5.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In TYPO3 4.2 tslib_cObj::substituteMarkerArray() has become a simple wrapper for the newly introduced method t3lib_parsehtml::substituteMarkerArray(). This new method can be called with 5 parameters, the last one of which makes it possible to remove unreplaced markers.

The wrapper tslib_cObj::substituteMarkerArray() has only 4 parameters and thus cannot activate the replacement of unused markers, because the default in t3lib_parsehtml::substituteMarkerArray() is 0.

We should add the 5th parameter to tslib_cObj::substituteMarkerArray() and I propose to set its value to 1, because it makes sense to want to remove unused markers.

(issue imported from #M8385)


Files

bug8385.patch (1.24 KB) bug8385.patch Administrator Admin, 2008-05-13 12:54
bug8385-2.patch (1.25 KB) bug8385-2.patch Administrator Admin, 2008-05-13 17:15
Actions #1

Updated by Steffen Kamper over 16 years ago

+1, go ahead!

Actions #2

Updated by Francois Suter over 16 years ago

Shouldn't you be answering in the core list?

Actions #3

Updated by Steffen Kamper over 16 years ago

seems going so quick today, i havn't seen this on core list :)

DD08 seems to be a very good motivator!

Actions #4

Updated by Francois Suter over 16 years ago

Added updated patch using boolean values instead of integers and setting default to false for 5th parameter.

Actions #5

Updated by Oliver Hader over 16 years ago

Committed to TYPO3_4-2 (rev. 3648)

Actions

Also available in: Atom PDF