Project

General

Profile

Actions

Bug #18861

closed

config.removeDefaultJS=1 leaves empty script block

Added by Philipp Heine over 16 years ago. Updated about 16 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Communication
Target version:
-
Start date:
2008-05-27
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The TypoScript line:

page.config.removeDefaultJS = 1

left a code Block like
<script type="text/javascript">
/*<![CDATA[*/

/*]]>*/
</script>

in the HTML header part instead of removing all of the JavaScript.

(issue imported from #M8527)


Files

0008527.patch (635 Bytes) 0008527.patch Administrator Admin, 2008-06-05 00:34
Actions #1

Updated by Philipp Heine over 16 years ago

Is there somebody else with this problem?

Actions #2

Updated by Andreas Wagner over 16 years ago

Yes, I can confirm this. But it seems this line is not needed anymore. When I remove config.removeDefaultJS = 1, the default javascript is moved to an external file anyway.

Actions #3

Updated by Tomas Mrozek over 16 years ago

"But it seems this line is not needed anymore."

Not needed? Well, how can you get rid of the JavaScript then?
In my opinion, the setting is still needed and the JavaScript should be removed completely and not leave an empty block in the code.

Actions #4

Updated by Oliver Hader over 16 years ago

The attached patch solves this issue. The reason was, that the script tag was added for inline JavaScript, even when there wasn't any.

Actions #5

Updated by Steffen Kamper over 16 years ago

and old behaviour was
page.config.removeDefaultJS = 1
but it has to be
page.config.removeDefaultJS = external

who invited the cow? :-)

Actions #6

Updated by Tomas Mrozek over 16 years ago

"page.config.removeDefaultJS = external"

Is that a proposal or is this supposed to be already implemented?

Actions #9

Updated by Steffen Kamper over 16 years ago

but only in "compatibility mode" ;-)

Actions #10

Updated by Tomas Mrozek over 16 years ago

OK...

"page.config.removeDefaultJS = 1" removes the JavaScript but leaves empty JavaScript code.

"page.config.removeDefaultJS = external" moves the JavaScript into a temporary file and includes that file.

The question is: How do you get rid of the JavaScript altogether so as to get the old behaviour?

Actions #11

Updated by Oliver Hader over 16 years ago

Tomas: What do you want to get rid of? Of the emptry script tag? If so, test the attached patch.

Actions #12

Updated by Tomas Mrozek over 16 years ago

Tested. Your patch works. +1
Thanks!

I guess I got totaly confused by Steffen's comments.

Actions #13

Updated by Steffen Kamper over 16 years ago

sry for the confusion. It was my mistake as i remembered struggling with this setting a while ago ...

Actions #14

Updated by Oliver Hader over 16 years ago

Committed to SVN:
  • TYPO3_4-2 (rev. 3759)
  • Trunk (rev. 3760)
Actions

Also available in: Atom PDF