TYPO3 Core

I also think that a final reset($array) is missing. This had been done in former versions of TYPO3.

The behavior of the $limit parameter is correct according to http://php.net/explode

... currently the either the documentation for the $limit parameter is wrong or the implementation for the documented behavior

the documentation of the parameter however fits the one of http://www.php.net/manual/en/function.array-slice.php

the attached patch makes the method behave like advertised in the description

Looks good... +1 on reading

committed to trunk (4.3)

Reopened... the behaviour will be reworked...

Added a follow-up patch, that come back to the behaviour of the original explode() function in PHP:

Example:

t3lib_div::trimExplode(",", " a , b , c , d, ,e, f , , ", true, 3);
will be array("a", "b", "c,d,e,f")

Using the RegExp "t3lib_div::trimExplode\([^)]+,\s*[2-9]\s*\)" to find parts where this is used in the core I got the following:
t3lib_extMgm:544: $itemDetails = t3lib_div::trimExplode(';', $itemPart, false, 5);

Committed the follow-up patch to SVN Trunk (rev. 6180)