Project

General

Profile

Actions

Bug #19771

closed

common.js uses undefined variable

Added by Dmitry Dulepov almost 16 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2009-01-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

common.js contains the following blocks of code:

} else if (!json) {
    T3AJAX.showError(xhr, json);
} else {

This code is called when JSON cannot be parsed and therefore the value is undefined. So there is no point to pass it anywhere. The function T3AJAX.showError() does not use this value anyway.

The attacjed patch removes this parameter from the function call and also shows ExtJS alert instead of standard browser if ExtJS is available.

I believe that this code is responsible for showing "undefined" messages with FireBug active.

(issue imported from #M10067)


Files

10067.diff (1007 Bytes) 10067.diff Administrator Admin, 2009-01-06 19:28

Related issues 1 (0 open1 closed)

Has duplicate TYPO3 Core - Bug #19795: Javascript error shown in BE after login (no user interaction)ClosedOliver Hader2009-01-12

Actions
Actions #1

Updated by Steffen Kamper almost 16 years ago

This sounds absolute logic, passing undefined var must lead to an error. Good catch!

Actions #2

Updated by Oliver Hader almost 16 years ago

Committed to SVN Trunk (rev. 4697) by Dmitry

Actions

Also available in: Atom PDF