Project

General

Profile

Actions

Bug #20910

closed

speed up list module by improving internal handling of localisations

Added by Rupert Germann over 14 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2009-08-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Problem:
The handling of translations in the list module (localization view) is inefficient.
2 SQL queries will be executed to find existing localisations and for showing the localisation panel. Both queries are basically the same, only the selected fields are changed. Additionally the list module instantiates a new object of class.t3lib_transl8tools for each record which is shown in the list.
class t3lib_transl8tools is initiated in exactly the same way each time (no constructor or other changing vars)

Solution:
Make only one query to find localizations and re-use the result.
initialize class transl8tools only once in function start() in class.db_list.inc and re-use it.

Benchmarks:
time for displaying a list of 100 records (single table view, Localization view=1). Page has 2 alternative page languages

trunk = ~115ms
patched = ~97ms

measured in class.db_lis.inc function generatedList()

(issue imported from #M11764)


Files

11764_optimize_transHandling.diff (5.57 KB) 11764_optimize_transHandling.diff Administrator Admin, 2009-08-21 16:28
11764_v2.diff (6.04 KB) 11764_v2.diff Administrator Admin, 2009-08-24 11:38
11764_followup2.diff (1.75 KB) 11764_followup2.diff Administrator Admin, 2009-11-16 11:05

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #21140: translateTools not instantiated in t3lib/class.t3lib_recordlist.phpClosedRupert Germann2009-09-25

Actions
Related to TYPO3 Core - Bug #21615: Fatal error: Call to a member function getSystemLanguages()ClosedOliver Hader2009-11-19

Actions
Actions #1

Updated by Rupert Germann over 14 years ago

committed v2 to trunk rev 5814

Actions #2

Updated by Rupert Germann over 14 years ago

attached patch "11764_followup2.diff" fixes the problems in extensions which use their own page-module.

committed followup2 to trunk, rev 6424

thanks Steffen

Actions

Also available in: Atom PDF