Project

General

Profile

Actions

Bug #21961

closed

collapseAll => 0 not working

Added by Jari no-lastname-given almost 15 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Won't have this time
Assignee:
-
Category:
-
Target version:
-
Start date:
2010-01-15
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Setting collapseAll => 0 had no effect for me, all items stayed collapsed.

I've experienced this issue with typo3 4.2.10 as well.

After investigating the source i've fixed this issue by modifieing
t3lib/class.t3lib_tceforms_inline.php

Replaced

$collapseAll = (isset($config['appearance']['collapseAll']) && $config['appearance']['collapseAll']);

with

$collapseAll = (!isset($config['appearance']['collapseAll']) || $config['appearance']['collapseAll']);

Replaced

if (!$isExpanded) {
$appearanceStyleFields = ' style="display: none;"';
}

with

if (!$isExpanded && $collapseAll) {
$appearanceStyleFields = ' style="display: none;"';
}

Seems like its working now but not well tested yet.

My TCA:

'attributes' => array (
'exclude' => 0,
'label' => 'LLL:EXT:book_entries/locallang_db.xml:tx_bookentries_entries.attributes',
'config' => array (
'type' => 'inline',
'foreign_table' => 'tx_bookentries_entries_attributes_mm',
'foreign_field' => 'entriesid',
'foreign_unique' => 'attributesid',
'foreign_label' => 'attributesid',
'appearance' => array(
'collapseAll' => 0,
),
)
),

(issue imported from #M13246)

Actions #1

Updated by Steffen Ritter almost 15 years ago

did you try collapseAll=> false?

manual states boolean as type

(!isset($config['appearance']['collapseAll']) || $config['appearance']['collapseAll']);
is wrong... so the collapseAll will be accessed even if it is not set... && is the right way to go... (it cannot be true if its not set, so or does not make sense)

Actions #2

Updated by Georg Schönweger almost 14 years ago

same here, "collapseAll => false" or "collapseAll => 0" does not work, items stay collapsed. I'm using Typo3 4.2.17

Actions #3

Updated by Dmitry Dulepov about 13 years ago

  • Status changed from Needs Feedback to Closed
  • Priority changed from Should have to Won't have this time
  • Target version deleted (0)

Cannot reproduce, old bug (4.2), closing.

Actions

Also available in: Atom PDF