Project

General

Profile

Actions

Bug #21991

closed

Deleted combo records are still validated by TBE_EDITOR

Added by Marcel Greter about 14 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2010-01-19
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you use combo mode and remove a record that currently does not satisfy the validation, you cannot save the "page" anymore and get this error message: "The fields marked with a yellow exclamation mark are not yet correctly filled in. Please complete them properly"

As a test case you can use the IRRE Tutorial extension. Then edit a "m:n asymmetric combo" Hotel. Create a new offer and simply delete it without filling in anything. Then try to save the page. You should then get this error message. From that point on you have to reload the page (and possibly lose all changes you did so far).

On removal of the record, the relation record is set to display: none. Therefore the combined record is also hidden. But only the validation of the relation record is disabled, the one of the combined record is still active.

I did some short investigations, but it seems to be far too complex for me to figure out how to cleanly do this. As a reference here a call stack for class.t3lib_tceforms_inline.php:

renderForeignRecord
renderForeignRecordHeader
renderForeignRecordHeaderControl
... renders onclick=deleteRecord link
... which will only remove the validation of the relation record
renderCombinationTable
renderMainFields
... this is where more (combined) required fields are added

There is also some hidden input field rendered in getSingleField_typeInline with class inlineRecord. That may have to do something with this, but I'm not sure.

(issue imported from #M13294)


Files

typo3_hotfix_13294.patch (1.27 KB) typo3_hotfix_13294.patch Administrator Admin, 2010-01-19 11:28

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #24372: Flexform inputfields remain empty regardless of valueClosedSteffen Kamper2010-12-20

Actions
Actions #1

Updated by Marcel Greter about 14 years ago

I added a patch which does solve the problem here. It's not done in a very clean way but IMO it should not break anything else. I simply mark the deleted div with class "inlineIsDeletedRecord" and check for any validated element if it is not contained within such a deleted record.

Quite simple and ugly, but should do the job.

Have a nice day,
Marcel Greter

Actions #2

Updated by Philipp Kerling over 13 years ago

What is the status of this?

Actions #3

Updated by Bernhard Czech over 13 years ago

Marcel Greter's patch also works for 4.4.3 and 4.4.4

Actions #4

Updated by Susanne Moog over 13 years ago

4-4 rev 9165
trunk rev 9166

Actions #5

Updated by Ernesto Baschny almost 11 years ago

  • Target version deleted (1088)
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF