Bug #21991
closedDeleted combo records are still validated by TBE_EDITOR
0%
Description
If you use combo mode and remove a record that currently does not satisfy the validation, you cannot save the "page" anymore and get this error message: "The fields marked with a yellow exclamation mark are not yet correctly filled in. Please complete them properly"
As a test case you can use the IRRE Tutorial extension. Then edit a "m:n asymmetric combo" Hotel. Create a new offer and simply delete it without filling in anything. Then try to save the page. You should then get this error message. From that point on you have to reload the page (and possibly lose all changes you did so far).
On removal of the record, the relation record is set to display: none. Therefore the combined record is also hidden. But only the validation of the relation record is disabled, the one of the combined record is still active.
I did some short investigations, but it seems to be far too complex for me to figure out how to cleanly do this. As a reference here a call stack for class.t3lib_tceforms_inline.php:
renderForeignRecord
renderForeignRecordHeader
renderForeignRecordHeaderControl
... renders onclick=deleteRecord link
... which will only remove the validation of the relation record
renderCombinationTable
renderMainFields
... this is where more (combined) required fields are added
There is also some hidden input field rendered in getSingleField_typeInline with class inlineRecord. That may have to do something with this, but I'm not sure.
(issue imported from #M13294)
Files
Updated by Marcel Greter almost 15 years ago
I added a patch which does solve the problem here. It's not done in a very clean way but IMO it should not break anything else. I simply mark the deleted div with class "inlineIsDeletedRecord" and check for any validated element if it is not contained within such a deleted record.
Quite simple and ugly, but should do the job.
Have a nice day,
Marcel Greter
Updated by Bernhard Czech about 14 years ago
Marcel Greter's patch also works for 4.4.3 and 4.4.4