Project

General

Profile

Actions

Bug #22095

closed

no alternative icon returned from 'getIcon' in class.t3lib_iconworks.php (backend-redesign)

Added by Stephan Kellermayr almost 15 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2010-02-09
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

current situation:
the function 'getIcon' checks if an icon with the current states (hidden/timing/futuretiming/protected...) is available and returns this.
but if we are using an extension which overrides some icons AND provides additional icons which are NOT available in the source (i.e.: for some states which would be normally displayed with 'icon_not_found.gif' or the appendix '*__x.gif') it does not return the new icon, because there is no check to the alternative path given by $GLOBALS['TBE_STYLES']['skinImgAutoCfg']['absDir']

in fact there is no possibility to improve the backend with replacements for missing icons at this time.

...thats why the following modification would be fine for backend-redesigner and other people who wants to improve the default icon-set:

replace line 251:
if (@is_file(dirname($absfile).'/'.$iconFileName_stateTagged)) { // Look for [iconname]_xxxx.[ext]

with this line:
if (@is_file(dirname($absfile).'/'.$iconFileName_stateTagged) || @is_file($GLOBALS['TBE_STYLES']['skinImgAutoCfg']['absDir'].'/'.dirname($iconfile).'/'.$iconFileName_stateTagged)) { // Look for [iconname]_xxxx.[ext]

this will also check the location of the alternative icons added by an extension and finally returns the new icon.

(issue imported from #M13487)


Files

Actions #1

Updated by Chris topher over 14 years ago

Hi Stephan,

thanks again for your work here!
The same as with your other patch (#22254):
Please create a unified diff and post it to the Core list!

For more information see here:
http://typo3.org/teams/core/core-mailinglist-rules/

Actions #2

Updated by Xavier Perseguers over 14 years ago

- trunk (rev. 7241)
- 4-3 (rev. 7242)

Actions #3

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF