Project

General

Profile

Actions

Bug #22166

closed

Status Report reports "Install Tool: disabled" when it is not.

Added by Gregor Hermens about 14 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2010-02-23
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

After upgrade of TYPO3 source 4.3.1 -> 4.3.2 Status Report reports "Install Tool: disabled" when it is not.

Typo3: 4.3.2
Reports: 1.0.0

Checked with two installations on the same server, sharing the same source.
(issue imported from #M13630)


Files

bug_13630.diff (3.44 KB) bug_13630.diff Administrator Admin, 2010-02-23 15:49
bug_13630v2.diff (4.11 KB) bug_13630v2.diff Administrator Admin, 2010-02-24 08:45
bug_13630v3.diff (4.12 KB) bug_13630v3.diff Administrator Admin, 2010-03-25 09:38
Actions #1

Updated by Gregor Hermens about 14 years ago

Looks like reports/status/class.tx_reports_reports_status_securitystatus.php line 251 has been changed from

if ($enableInstallToolFileExists || ($enableInstallToolFileExists && trim(file_get_contents($enableInstallToolFile)) === 'KEEP_FILE')) {

to

if ($enableInstallToolFileExists && trim(file_get_contents($enableInstallToolFile)) === 'KEEP_FILE') {

without mentioning this in ChangeLog or increasing the version number.

Actions #2

Updated by Gregor Hermens about 14 years ago

This bug relates to #21848, from where above change originates.
As I think that tx_reports should always report the correct status of the install tool, whereas tx_modules doesn't have to be too picky about that, I have attached a patch that differentiates between permanently or just temporarily activated install tool.

Actions #3

Updated by Gregor Hermens about 14 years ago

Attached patch bug_13630v2.diff checks the age of the ENABLE_INSTALL_TOOL file. If the file doesn't contain 'KEEP_FILE' and is older than 3600s it is deleted, else the remaining time to live is displayed in the status report.

Actions #4

Updated by Gregor Hermens about 14 years ago

Patch bug_13630v3.diff lowers the severity from warning to notice and reports the remaining time to live in minutes.

Actions #5

Updated by Susanne Moog about 14 years ago

FYI: committed v3 to
trunk rev 7376
4_3 rev 7377

Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF