Project

General

Profile

Actions
Copy link

Bug #22247

closed

page.jsInline / page.jsFooterInline may fail with config.removeDefaultJS=external

Added by Steffen Ritter over 14 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Jeff Segars
Category:
-
Target version:
-
Start date:
2010-03-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

jsInline and jsFooterInline are build from cObject-Array.
These may contain _INT objects. INT-Objects are put as markers in content, and replaced before delivery by TSFE.

removeDefaultJS=external moves the inlineJS to an external file. If there are markers for INT-Objects they are moved to external file too (where it never will be substituted).

The result is, that
a, the JS file will raise JS-Errors
b, the INT-Object JS is not present

This means: INT-Object must not relocated to an external file, since this is not compatible with TYPO3 INT-object handling.

Solution: Extract the markers before moving to external file and include INT-Objects still inline .

(issue imported from #M13758)

Files

Download all files
inlineINTfix.diff (1.38 KB) inlineINTfix.diff Administrator Admin, 2010-03-06 18:54
rfc13758-inlineJS_v3.diff (2.74 KB) rfc13758-inlineJS_v3.diff Administrator Admin, 2010-04-30 10:27
rfc13758-inlineJS_v5.diff (2.63 KB) rfc13758-inlineJS_v5.diff Administrator Admin, 2010-04-30 15:21
rfc13758-inlineJS_v7.diff (2.7 KB) rfc13758-inlineJS_v7.diff Administrator Admin, 2010-04-30 18:23
Actions
Copy link
 #1

Updated by Steffen Ritter over 14 years ago

Use following TS to test, have a look at the results with removeDefaultJS=0
and removeDefaultJS=external ( the filecontent then)
with and without the patch.

page.jsInline {
500 = COA_INT
500.10 = TEXT
500.10.value = var INT1 =true; 

1000 = TEXT
  1000.value = var cachableTest = true;
2000 < .500
}
Actions
Copy link
 #2

Updated by Andy Grunwald over 14 years ago

Added the last patch.
see mailling lists for details

Actions
Copy link
 #3

Updated by Jeff Segars over 14 years ago

Committed the attached v7 to trunk (r7463) and 4_3 (r7464)

Actions
Copy link

Also available in: Atom PDF