Project

General

Profile

Actions

Bug #22370

closed

Content Element Media and Render Type "HTML Embed Element" not working

Added by Ingo over 14 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2010-04-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Add a Content Element Media, Media File was a local .wmv and Render Type was set to "HTML Embed Element". No output in frontend.

In class.tslib_content, function MEDIA we find a switch ($renderType) that supports the following cases "swf", "qt", "media" and a default-case for everything else, that looks for a hook.

renderType from the backend for "HTML Embed Element" is set to "embed" so we run into the default-case which looks for a hook which is not available. instead the case "media" renders the excpected embed-element.

for me to get the embed-element working i just changed

case 'media':
...
break;

to

case 'embed':
case 'media':
...
break;

issue is in 4.3.0 and 4.3.2

(issue imported from #M13991)


Files

issue_13991.diff (596 Bytes) issue_13991.diff Administrator Admin, 2010-04-12 11:32
13991_v2.diff (649 Bytes) 13991_v2.diff Administrator Admin, 2010-04-19 17:20
Actions #1

Updated by Administrator Admin over 14 years ago

I can confirm this. Patch attached.

Actions #2

Updated by Steffen Gebert over 14 years ago

Would one of you send this patch to the core list?
Instructions (german) on http://typo3blogger.de/ab-in-den-core/

Otherwise I try to have a look the next days.

Actions #3

Updated by Administrator Admin over 14 years ago

Sorry got no time yesterday. I sent it to the core list now.

Actions #4

Updated by Steffen Gebert over 14 years ago

Perfect, thanks!

Actions #5

Updated by Ingo about 14 years ago

can someone shed some light on which case would be the correct one ?
i mean why support both "media" and "embed" if only one of them will be valid.
or is it really both cases that are valid ?

Actions #6

Updated by Steffen Kamper about 14 years ago

only embed is valid, media was used before initial commit.

Is corrected in trunk and 4_3 now.

Actions #7

Updated by Steffen Kamper about 14 years ago

Committed attached v2 to svn
4_3 rev 7389
trunk rev 7390

Actions #8

Updated by Benni Mack almost 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF