Bug #22799
closedrootline says "pid" where it should be "uid" or just "ID"
0%
Description
The rootline shown in the upper right corner of the working area always says "pid" where it should be "uid" or just "ID", because "pid" is the parent id of any record (even pages) and not the page id.
The number which is shown there is the value of the fields
"uid" for pages (so "pid" is wrong here)
"pid" for other records
Is this by intention?
IMHO "ID" should be the way to go because it's "neutral" and works for each case.
(issue imported from #M14605)
Files
Updated by Chris topher over 14 years ago
Hi Joey,
using ID is better then what we have now.
But just using ID might also be confusing, because this "ID" would then be the same for a BE user and a page (for example).
What about using a word(!), e.g. "User 15" or "Page 225"?
Or another possibility: Do we need this value there at all? I mean you already have some information about the record you currently edit in the line below the title...
If you choose to keep it, please use a locallang-label for the text. ;-) Thanks!
Updated by Jo Hasenau over 14 years ago
I found out it's even worse than I thought,
Take a look at the attached sceenshots.
When you create a new page the rootline path shows
site name <icon> [pid:0 (root)]
while the title below says
<icon> Page NEW - [PID:3] Page 2
The reality is: I created a new page as subpage of a page named "Page 2". "Page 2" has got the ID 3
Now that I created this page and called it "Whatever" the new situation is:
Rootline shows
/Root/Page 2/Whatever/<icon> [pid: 39]
title below says
<icon> Page [39] - Whatever
The reality is: Page "Whatever" is now a subpage of "Page 2" and has got the ID 39
It's not as bad for content but still confusing:
When I create a new content element, the path shows:
/Root/Page 2/<icon> [pid: 3]
and the title says
<icon> Pagecontent NEW - [PID: 3] Page 2
The reality is: I created a new content element on Page 2. The page has got the ID 3
When the element already exists the path shows:
/Root/Page 2/<icon> [pid: 3]
and the title says
<icon> Pagecontent [1] - whatever
The reality is: The content element "Whatever" got the ID 1 and can be found on the page "Page 2" which got the ID 3.
I think nobody would ever come close to the reality when just guessing it from the information shown in path and title.
Let's try to find an overall solution that will be guiding instead of misleading.
Updated by Steffen Kamper over 14 years ago
intention was pid - parent id and not the id. The id is shown in edit / create page already. But, true, sometimes uid is shown instead of pid.
So i suggest to show real pid always or drop it completely.
Updated by Jo Hasenau over 14 years ago
For the rootline just dropping the [pid:123] stuff would not be enough, since the path still would look confusing:
/Root/Page 2/<icon>
Actually the icon belongs to "Page 2" here so the path should be
/Root/<icon> Page 2
On the other hand the ID information is something we should keep because it helps to identify stuff. The number in brackets should be enough so we could kick the "pid:"
So what about this rootline:
/Root/<page icon> Title [123]
this one for the NEW records:
<page icon> NEW Page - <page icon> Title [123]
<content icon> NEW Pagecontent - <page icon> Title [123]
and this one for existing records:
<page icon> Page Title [456] - <page icon> Title [123]
<content icon> Pagecontent Title [456] - <page icon> Title [123]
This way the combination <page icon> Title [123] would be consistent for each case
Updated by Reinhard Führicht over 14 years ago
I had a quick look at the code, and it seems that in case of creating a new page, there is no uid and no pid at the time the page info box is created. Therefore, there would alwas be
Path: [Sitename] [pid: 0 (root)]
Changing the label from pid to uid for existing records or removing it completely should be easy, but not knowing about the real pid when creating a page is a big problem. The closest solution would be to remove the page info for new pages and show it only if a uid exists.
Updated by Steffen Kamper over 14 years ago
I looked again to this issue and i see no easy bugfixing method without breaking compatibility.
Reason is that PAGEPATH and PAGEINFO are different markers. The only quick fix i see is removing "pid:" - it's usual at other places too to add id in square brackets.
- moving path to the left side
- add links to the path, so you can click on each page of the path like you know from webpages
- omit the current page
then add [icon] title [id] direct after the path without trailing slash
Updated by Steffen Kamper over 14 years ago
I attached a possible fix for the page path, see also screenshot