Project

General

Profile

Actions
Copy link

Bug #22822

closed

caching framework memcached backend: No exception thrown if set() fails and wrong boolean comparison

Added by Christian Kuhn over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Christian Kuhn
Category:
Caching
Target version:
-
Start date:
2010-06-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Problem:
No exception in memcachedbackend->set() is thrown if memcache->set() fails, so test setThrowsExceptionIfConfiguredServersAreUnreachable() fails.

Adding the Exception reveals a problem with the $success handling and test largeDataIsStored() fails: Bitwise & of boolean parameters returns an integer, so 'if ($success === TRUE) {' is too strict.

Solution:
Add exception if memcache->set() was not successful and change bitwise $success handling to logical comparison.

(issue imported from #M14632)

Files

14632_01.diff (1.2 KB) 14632_01.diff Administrator Admin, 2010-06-06 15:35
Actions
Copy link

Also available in: Atom PDF