Bug #23134: FF field "Forgot Password Message" in felogin not working - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #23134

closed

FF field "Forgot Password Message" in felogin not working

Added by Steffen Müller almost 14 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Steffen Kamper

Category:

felogin

Target version:

Start date:

2010-07-08

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Problem:

The value of the FF field "Forgot Password Message" (see screenshot) in felogin is not working. No matter what you type in that field, the text in the forget password form does not change.
The reason for this is that the field is not used at all in typo3/sysext/felogin/pi1/class.tx_felogin_pi1.php

The FF field name is "forgot_message"
pi1 class uses "forgot_reset_message" instead

Solution:

Change pi1 class to use forgot_message instead of
forgot_reset_message and alter locallang file accordingly.

(issue imported from #M15051)

Files

Download all files

bug_15051.diff (2.4 KB) bug_15051.diff		Administrator Admin, 2010-07-08 18:14
15051_v2.patch (3.28 KB) 15051_v2.patch		Administrator Admin, 2011-03-27 22:40
23134_solution2.diff (1.98 KB) 23134_solution2.diff		Steffen Müller, 2011-04-11 22:39

Actions

Copy link

Updated by Andreas Otto † almost 14 years ago

+1 by reading and testing

Actions

Copy link

Updated by Sebastian Meyer about 13 years ago

When will this get fixed? There is a working patch since more than 8 months...

Actions

Copy link

Updated by Steffen Kamper about 13 years ago

https://review.typo3.org/1285

Actions

Copy link

Updated by Steffen Müller about 13 years ago

File 23134_solution2.diff 23134_solution2.diff added

There were two major solutions for this issue:
1. Rename the FF field --> will lead to empty fields in existing plugin instances.
2. Change pi1 class to use forgot_message instead of forgot_reset_message and change locallang accordingly.

Both approaches were discussed in dev-mailinglist where solution no.1 was preferred.

and then voted in core-mailinglist where no.2 was preferred.

The main argument for no.2 was to avoid backward incompatibilities by keeping the existing translations.
Backdraw is of no.2 is inconsistent field labels.

So here comes a new patch for solution no.2

Actions

Copy link