Project

General

Profile

Actions

Bug #23352

closed

htmlArea RTE: Remove link option not enabled on double-click in Firefox

Added by Lorenz Ulrich over 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2010-08-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Maybe I'm just a little old-fashioned, but I liked the context menu item "Remove link" that appeared when a link was set in htmlarearte < version 2. Could it be integrated again?

(issue imported from #M15354)


Files

rte_removelink_43.jpg (26.5 KB) rte_removelink_43.jpg Administrator Admin, 2010-08-05 23:37
rtehtmlarea_bugfix_15354_trunk.patch (2.37 KB) rtehtmlarea_bugfix_15354_trunk.patch Administrator Admin, 2010-08-29 08:27
rtehtmlarea_bugfix_15354_follow_up_trunk.patch (2.38 KB) rtehtmlarea_bugfix_15354_follow_up_trunk.patch Administrator Admin, 2010-08-30 02:52
Actions #1

Updated by Stanislas Rolland over 13 years ago

If button "unlink" is configured in the toolbar, it should appear in the context menu.

Actions #2

Updated by over 13 years ago

Ah, I just found out what is different in 4.4 compared to 4.3.

In 4.3, after double-clicking a link I had the "Remove link" option in the context menu but the toolbar icon was inactive.

To have the option and the toolbar icon active I had to highlight it (not by double-click, but by mouse selection).

In 4.4+ you don't have the option in the context menu after double-clicking.

Actions #3

Updated by Stanislas Rolland over 13 years ago

In what browser?

Actions #4

Updated by over 13 years ago

Sorry, forgot to mention that: Firefox 3.6.

Actions #5

Updated by Stanislas Rolland over 13 years ago

The problem in 4.3 was that the toolbar and the context menu were inconsistent.

In all browsers other than Firefox, double-click on the link selects exactly the link, and the unlink icon is enabled in both the toolbar and the context menu.

But Firefox put the boundaries of the selection just outside the link...

The problem is reported on bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=569190

Actions #6

Updated by Stanislas Rolland over 13 years ago

Attached patch should fix this in Firefox.

Please confirm.

Actions #7

Updated by over 13 years ago

Just tested - works fine. Thanks a lot!

Actions #8

Updated by Stanislas Rolland over 13 years ago

Thanks for testing!

Committed to SVN TYPO3core trunk (revision 8734) and branch TYPO3_4-4 (revision 8735).

Actions #9

Updated by Stanislas Rolland over 13 years ago

Just realized that the same issue would arise with the non-typo3 link editing plugin used in the FE.

So, attaching follow-up patch

Actions #10

Updated by Stanislas Rolland over 13 years ago

Follow-up patch committed to SVN TYPO3core trunk (revision 8736) and branch TYPO3_4-4 (revision 8737).

Actions

Also available in: Atom PDF