Bug #23373
closed
Changes made by ColorPicker Wizard are not saved
0%
Description
When I enhance a form in a Templavoila Datastructure with the standard color picker (wizard typo3/wizard_colorpicker.php), changes made using the color picker wizard are not saved. Changes made directly in the form fields are saved as expected.
I suspect that the problem might not be restricted to TV in any way, but is a general bug in the color picker wizard.
Closer investigation showed that the wizard changes only the visible form fields in the backend form (the ones with _hr appended) and leaves the hidden fields untouched.
The setValue javascript functions are not set in wizard_colorpicker.php once the wizard form has been submitted once (i.e. a color has been chosen). The reason seams to be the missing preservation of the security hash fieldChangeFuncHash in the hidden form fields of the wizard. I added a small patch to add the hidden field, that fixed that problem for me.
(issue imported from #M15456)
Files
Updated by Tobias Hoevelborn over 13 years ago
Added bug_0015456_2.patch file, just a cleaned up version.
Updated by Michael Voehringer over 13 years ago
I can confirm this bug. It have a similar problem using the colorpicker in an plugin. Your patch fixes my problem. Thank you very much.
Updated by Chris topher over 13 years ago
Hi Tobias,
thanks for your patch!
Would you mind sending this to the Core Team list, to get this committed to the TYPO3 sources? Please choose as branches 4-4 and trunk (if it applies to 4-3, then this one, too).
You can find a how-to here: http://typo3blogger.de/ab-in-den-core/ (I assume you're German ;)).
If you have any questions, don't hesistate to ask!
Thanks for your contribution!
Updated by Tobias Hoevelborn over 13 years ago
Hi Christopher,
thanks you for your hint, bug and patch are sent to Core Team List.
Bye
Updated by Chris topher over 13 years ago
Oh, I must have overlooked the thread.
You can send a reminder to the thread in Core List up to once a week to get a bit more attention!
A +1 by a Core Dev is still missing.
Updated by Tobias Hoevelborn over 13 years ago
Sorry Christopher, what I meant to say is I tried to send after recieving your helpfull hint, you didn't overlook anything.
But I just recieved the notice that my post has been rejected :-/ Got no idea what I missed out or did wrong hence asked the list owner for feedback... I'll keep trying.
It worked with a newsreader. Thanks again.
Updated by Chris topher over 13 years ago
What a mess:
I mean, the patch has already been posted on 13.9. by Christian Müller.
That is what I overlooked when telling you to post it. Now there are 2 threads about that issue... Sorry for the inconvenience, it was my mistake.
Could you use the one started by Christian and just post a reminder there?
That would be helpful as people have already voted for your patch there.
And maybe tell people to use "that" thread. ;-)
Updated by Ernesto Baschny over 13 years ago
Committed to:
- trunk, rev. 9349 (will be in 4.5 beta1)
- 4.4, rev. 9350 (will be in 4.4.5)
- 4.3, rev. 9351 (will be in 4.3.8)
- 4.2, rev. 9352 (will be in 4.2.16)
Updated by