Bug #23440
closed
naming of parameter $compressed in t3lib_PageRenderer::addCssInlineBlock()
0%
Description
Line: 736
public function addCssInlineBlock($name, $block, $compressed = FALSE, $forceOnTop = FALSE) {
Variable '$compressed' has to be renamed to '$compress' as described in phpdoc block (@param boolean $compress). This is equivalent to other methods in this class.
original text:
Line: 736
public function addCssInlineBlock($name, $block, $compressed = FALSE, $forceOnTop = FALSE) {
Variable '$compressed' muss, äquivalent zu anderen Methoden in dieser Klasse, '$compress' heißen. So ist es auch im docblock beschrieben (@param boolean $compress)
(issue imported from #M15545)
Files
Updated by Jesse Adler almost 14 years ago
Sorry, I forgot to write in english. Shame on me!
Line: 736
public function addCssInlineBlock($name, $block, $compressed = FALSE, $forceOnTop = FALSE) {
Variable '$compressed' has to be renamed to '$compress' as described in phpdoc block (@param boolean $compress). This is equivalent to other methods in this class.
Updated by Steffen Gebert almost 14 years ago
Jesse, can you create a patch for this?
Updated by Jesse Adler almost 14 years ago
added patch for TYPO3 4.3.5
t3lib/class.t3lib_pagerenderer.php (revision 8688)
Updated by Steffen Gebert almost 14 years ago
Thanks for your patch, Jesse. But when you rename a variable once, you have to rename it everywhere in the scope ;-)
Updated by Jesse Adler almost 14 years ago
Why should I?
It's misspelled in the functions' arguments, only. Everywhere else it is correct.
Updated by Alexander Opitz almost 11 years ago
- Status changed from New to Needs Feedback
- Target version deleted (
0) - Is Regression set to No
Hi,
as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (4.5 or 6.1)?
Updated by Alexander Opitz over 10 years ago
- Status changed from Needs Feedback to Closed
No feedback within the last 90 days => closing this ticket.
If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.