Bug #23603: Uninitialized variables in t3lib - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #23603

closed

Uninitialized variables in t3lib

Added by Oliver Klee over 13 years ago. Updated about 13 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Susanne Moog

Category:

Target version:

Start date:

2010-09-24

Due date:

% Done:

Estimated time:

TYPO3 Version:

4.5

PHP Version:

5.3

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

There are some uninitialized variables in some t3lib classes for several reasons:

- variable doesn't exist at all ~~> replace with sane default value~~
wrong variable ~~> replace with correct variable~~
typo -> fix

In addition, I've removed some commented-out code and dropped one useless self-assignment.

All these warnings have been detected by my IDE.
(issue imported from #M15799)

Files

Download all files

t3lib_undefinded_trunk_and_44.diff (13.9 KB) t3lib_undefinded_trunk_and_44.diff		Administrator Admin, 2010-09-24 18:32
t3lib_undefinded_43.diff (11.1 KB) t3lib_undefinded_43.diff		Administrator Admin, 2010-09-24 18:32
15799_v2_trunk.diff (12.8 KB) 15799_v2_trunk.diff		Administrator Admin, 2010-09-24 20:09
15799_v2_44.diff (12.3 KB) 15799_v2_44.diff		Administrator Admin, 2010-09-24 20:09
15799_v2_43.diff (10.4 KB) 15799_v2_43.diff		Administrator Admin, 2010-09-24 20:09

Actions

Copy link

Updated by Georg Ringer over 13 years ago

does "if (TRUE) {" really make sense?

Actions

Copy link

Updated by Oliver Klee over 13 years ago

I wanted to keep the changeset as small as possible. I propose we drop the condition (causing all the code inside the condition to change its indention) in a separate follow-up patch.

Actions

Copy link