Bug #23649

felogin::getPreserveGetVars() decode encoded values

Added by Peter Russ about 9 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Communication
Target version:
-
Start date:
2010-09-29
Due date:
% Done:

100%

TYPO3 Version:
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

if a urlencoded var is provided the method just forward the encode value. By doing this it's "adding" more parameter to the url with the result of a malfunction.

Check
&test=urlencode(7&test1=2&test2=3)

will create &test=7&test1=2&test2=3

which is wrong.

Patch attached.

(issue imported from #M15861)

15861.diff View (694 Bytes) Administrator Admin, 2010-09-29 19:59


Related issues

Related to TYPO3 Core - Bug #19938: warning: in_array wrong datatype Closed 2009-01-30

Associated revisions

Revision a0f4d13c (diff)
Added by Jigal van Hemert about 7 years ago

[BUGFIX] EXT:felogin: Multiple bugs with preserveGETvars

Refactor and fix handling of preserveGETvars in felogin. * Add support for multi dimensional arrays * urlencode() values * Preserve only parameters defined in 'preserveGETvars'

The patch adds a new ArrayUtility method to handle
recursive array intersections. See the unit tests for details.

Change-Id: I90e2f8eb79586369a9c15c7ef19f7658b1d65ed3
Fixes: #19938
Fixes: #23324
Fixes: #23649
Fixes: #36894
Fixes: #38589
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/7638
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 9eca09b0 (diff)
Added by Jigal van Hemert almost 7 years ago

[BUGFIX] EXT:felogin: Multiple bugs with preserveGETvars

Refactor and fix handling of preserveGETvars in felogin. * Add support for multi dimensional arrays * urlencode() values * Preserve only parameters defined in 'preserveGETvars'

The patch adds a new ArrayUtility method to handle
recursive array intersections. See the unit tests for details.

Change-Id: I90e2f8eb79586369a9c15c7ef19f7658b1d65ed3
Fixes: #19938
Fixes: #23324
Fixes: #23649
Fixes: #36894
Fixes: #38589
Releases: 6.0, 4.7
Reviewed-on: https://review.typo3.org/16452
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1 Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#2 Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#3 Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#4 Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#5 Updated by Gerrit Code Review over 7 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#6 Updated by Gerrit Code Review about 7 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#7 Updated by Gerrit Code Review about 7 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#8 Updated by Gerrit Code Review about 7 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#9 Updated by Gerrit Code Review about 7 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#10 Updated by Gerrit Code Review about 7 years ago

Patch set 12 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#11 Updated by Gerrit Code Review about 7 years ago

Patch set 13 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#12 Updated by Gerrit Code Review about 7 years ago

Patch set 14 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#13 Updated by Gerrit Code Review about 7 years ago

Patch set 15 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#14 Updated by Gerrit Code Review about 7 years ago

Patch set 16 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#15 Updated by Gerrit Code Review about 7 years ago

Patch set 17 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#16 Updated by Jigal van Hemert about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#17 Updated by Gerrit Code Review about 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/16452

#18 Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/16452

#19 Updated by Jigal van Hemert almost 7 years ago

  • Status changed from Under Review to Resolved

#20 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF