Bug #23861

t3lib_db::INSERTquery misses a space when generering the INSERT INTO statement

Added by Ernesto Baschny almost 9 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2010-10-28
Due date:
% Done:

0%

TYPO3 Version:
4.4
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Since #20947 (rev. 6203, 4.3.0 and later), a CGL cleanup on t3lib_db, the INSERTquery method generates a slightly non-conformant query:

INSERT INTO table(field1, field2) VALUES ($value1, $value2);

note the missing space after the tablename. Correct would be:

INSERT INTO table (field1, field2) VALUES ($value1, $value2);

While newer MySQL versions accept this silently, it might fail on pretty old MySQL servers.

And it is not that beautiful. :)

(issue imported from #M16155)


Related issues

Related to TYPO3 Core - Bug #20947: t3lib_db does not meet CGLs Closed 2009-08-28

History

#1 Updated by Ernesto Baschny almost 9 years ago

Commited to:

- trunk rev. 9218 (for 4.5beta1)
- TYPO3_4-4 rev. 9219 (for 4.4.5)
- TYPO3_4-3 rev. 9220 (for 4.3.9)

#2 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF