Project

General

Profile

Actions
Copy link

Feature #24110

closed

Performance Tunning : rewrite/clean t3lib_db->listQuery

Added by Popy no-lastname-given about 14 years ago. Updated almost 14 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2010-11-17
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Actually the listQuery method is based on 3 "LIKE" separated with OR, so there's 3 string comparaisons instead of just one.

Solution should be :
  • using "concat" to add comma before and after field value THEN compare this result to the "%,value,%" string
  • using mysql builtin FIND_IN_SET function

(issue imported from #M16451)

Files

Download all files
16451-concat.patch (563 Bytes) 16451-concat.patch Administrator Admin, 2010-11-17 17:44
16451-find-in-set.patch (542 Bytes) 16451-find-in-set.patch Administrator Admin, 2010-11-17 17:44
Actions
Copy link
 #1

Updated by Popy no-lastname-given about 14 years ago

BTW, while using LIKE, maybe escapeStrForLike should be used ?

Actions
Copy link
 #2

Updated by Georg Ringer about 14 years ago

listquery does already use find_in_set. please check trunk

Actions
Copy link
 #4

Updated by Georg Ringer about 14 years ago

no the official trunk ... long time already since TYPO3 moved ;) https://svn.typo3.org/TYPO3v4/Core/trunk/t3lib/class.t3lib_db.php

Actions
Copy link
 #6

Updated by Steffen Ritter almost 14 years ago

so this one can be closed, right?

Actions
Copy link
 #7

Updated by Georg Ringer almost 14 years ago

yes

Actions
Copy link

Also available in: Atom PDF