Task #24551: Adhere to CGL: t3lib_div::getUrl() instead of t3lib_div::getURL() - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #24551

closed

Adhere to CGL: t3lib_div::getUrl() instead of t3lib_div::getURL()

Added by Andreas Lappe almost 14 years ago. Updated over 11 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Ernesto Baschny

Category:

Target version:

Start date:

2011-01-13

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.6

PHP Version:

5.3

Tags:

Complexity:

Sprint Focus:

Description

Even though the case is not important in PHP I think it's a matter of consistency to call it the right way. This also makes it easier for people like me who use a case-sensitive search in their editor to find the right functions…

The patches are splitted because they affect different subprojects…

(issue imported from #M17008)

Files

Download all files

getURL-typo3.diff (1.04 KB) getURL-typo3.diff		Administrator Admin, 2011-01-13 14:13
getURL-t3lib.diff (17.2 KB) getURL-t3lib.diff		Administrator Admin, 2011-01-13 14:13
getURL-typo3-sysext-cms.diff (1.98 KB) getURL-typo3-sysext-cms.diff		Administrator Admin, 2011-01-13 14:13
getURL-typo3-sysext-dbal.diff (3.05 KB) getURL-typo3-sysext-dbal.diff		Administrator Admin, 2011-01-13 14:13
getURL-typo3-sysext-em.diff (9.11 KB) getURL-typo3-sysext-em.diff		Administrator Admin, 2011-01-13 14:13
getURL-typo3-sysext-impexp.diff (2.64 KB) getURL-typo3-sysext-impexp.diff		Administrator Admin, 2011-01-13 14:14
getURL-typo3-sysext-indexed_search.diff (1.88 KB) getURL-typo3-sysext-indexed_search.diff		Administrator Admin, 2011-01-13 14:14
getURL-typo3-sysext-install.diff (4.18 KB) getURL-typo3-sysext-install.diff		Administrator Admin, 2011-01-13 14:14
getURL-typo3-sysext-lowlevel.diff (685 Bytes) getURL-typo3-sysext-lowlevel.diff		Administrator Admin, 2011-01-13 14:14
getURL-typo3-sysext-tstemplate_info.diff (1.11 KB) getURL-typo3-sysext-tstemplate_info.diff		Administrator Admin, 2011-01-13 14:14
getURL-typo3-sysext-version.diff (2.14 KB) getURL-typo3-sysext-version.diff		Administrator Admin, 2011-01-13 14:14
getURL-typo3-sysext-workspaces.diff (1.18 KB) getURL-typo3-sysext-workspaces.diff		Administrator Admin, 2011-01-13 14:15
lowerCamelCase-getUrl-t3lib.diff (2.38 KB) lowerCamelCase-getUrl-t3lib.diff		Administrator Admin, 2011-01-13 16:43
lowerCamelCase-getUrl-typo3-sysext-cms.diff (605 Bytes) lowerCamelCase-getUrl-typo3-sysext-cms.diff		Administrator Admin, 2011-01-13 16:44
lowerCamelCase-getUrl-typo3-sysext-em.diff (6.17 KB) lowerCamelCase-getUrl-typo3-sysext-em.diff		Administrator Admin, 2011-01-13 16:44
lowerCamelCase-getUrl-typo3-sysext-indexed_search.diff (627 Bytes) lowerCamelCase-getUrl-typo3-sysext-indexed_search.diff		Administrator Admin, 2011-01-13 16:44
lowerCamelCase-getUrl-typo3-sysext-linkvalidator.diff (1.91 KB) lowerCamelCase-getUrl-typo3-sysext-linkvalidator.diff		Administrator Admin, 2011-01-13 16:44
lowerCamelCase-getUrl-typo3-sysext-lowlevel.diff (822 Bytes) lowerCamelCase-getUrl-typo3-sysext-lowlevel.diff		Administrator Admin, 2011-01-13 16:44
lowerCamelCase-getUrl-typo3-sysext-t3editor.diff (627 Bytes) lowerCamelCase-getUrl-typo3-sysext-t3editor.diff		Administrator Admin, 2011-01-13 16:45
lowerCamelCase-getUrl-typo3-sysext-tsconfig_help.diff (557 Bytes) lowerCamelCase-getUrl-typo3-sysext-tsconfig_help.diff		Administrator Admin, 2011-01-13 16:45
lowerCamelCase-getUrl-typo3.diff (1.67 KB) lowerCamelCase-getUrl-typo3.diff		Administrator Admin, 2011-01-13 16:45

Actions

Copy link

Updated by Ernesto Baschny almost 14 years ago

This is discussion-worthy. The CGL says CamelCase should also be done for acronyms like "URL" should also be CamelCases. So according to the CGL, "getUrl" is ok. Which is probably why new code is using this syntax.

So it might be worth thinking about changing t3lib_div to "getUrl()". What do you think? I'll throw the discussion in the core team. Thanks!

Actions

Copy link

Updated by Andreas Lappe almost 14 years ago

I attached the other way around…

Actions

Copy link

Updated by Ernesto Baschny over 13 years ago

Assignee set to Ernesto Baschny
Target version changed from 0 to 4.6.0-beta1

Actions

Copy link

Updated by Ernesto Baschny over 13 years ago

Tracker changed from Bug to Task
Subject changed from t3lib_div::getURL() gets called as t3lib_div::getUrl() to Adhere to CGL: t3lib_div::getUrl() instead of t3lib_div::getURL()
Status changed from New to Accepted
TYPO3 Version changed from 4.5 to 4.6