Task #24551
closedAdhere to CGL: t3lib_div::getUrl() instead of t3lib_div::getURL()
Added by Andreas Lappe almost 14 years ago. Updated over 11 years ago.
100%
Description
Even though the case is not important in PHP I think it's a matter of consistency to call it the right way. This also makes it easier for people like me who use a case-sensitive search in their editor to find the right functions…
The patches are splitted because they affect different subprojects…
(issue imported from #M17008)
Files
Updated by Ernesto Baschny almost 14 years ago
This is discussion-worthy. The CGL says CamelCase should also be done for acronyms like "URL" should also be CamelCases. So according to the CGL, "getUrl" is ok. Which is probably why new code is using this syntax.
So it might be worth thinking about changing t3lib_div to "getUrl()". What do you think? I'll throw the discussion in the core team. Thanks!
Updated by Ernesto Baschny over 13 years ago
- Assignee set to Ernesto Baschny
- Target version changed from 0 to 4.6.0-beta1
Updated by Ernesto Baschny over 13 years ago
- Tracker changed from Bug to Task
- Subject changed from t3lib_div::getURL() gets called as t3lib_div::getUrl() to Adhere to CGL: t3lib_div::getUrl() instead of t3lib_div::getURL()
- Status changed from New to Accepted
- TYPO3 Version changed from 4.5 to 4.6
Updated by Mr. Hudson over 13 years ago
Patch set 1 of change If9ad418a4a70985cd661d1dd9c6f07498e833d95 has been pushed to the review server.
It is available at http://review.typo3.org/3111
Updated by Ernesto Baschny over 13 years ago
- Status changed from Accepted to Resolved
- % Done changed from 0 to 100
Applied in changeset 196503967fb2d7184b1d3447a8c5a9b9ff82a21d.
Updated by Xavier Perseguers over 12 years ago
- Status changed from Resolved to Closed
Updated by Ernesto Baschny over 11 years ago
- Target version deleted (
4.6.0-beta1)