Project

General

Profile

Actions
Copy link

Bug #25090

closed

Cleanup: Replace deprecated assertType in unit tests

Added by Alexander Stehlik about 13 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-02-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

"assertType() will be removed in PHPUnit 3.6 and should no longer be used. assertInternalType() should be used for asserting internal types such as "integer" or "string" whereas assertInstanceOf() should be used for asserting that an object is an instance of a specified class or interface."

I'll attach a patch that replaces all assertType calls with the new assertInstanceOf or assertInternalType methods.

(issue imported from #M17657)

Files

typo3-17657-unit_test_assertType.diff (1.9 KB) typo3-17657-unit_test_assertType.diff Administrator Admin, 2011-02-18 18:05
Actions
Copy link
 #1

Updated by Mr. Hudson almost 13 years ago

Patch set 1 of change I8fd91f031634e43a34ab1d3b75869452a8dd4d6a has been pushed to the review server.
It is available at http://review.typo3.org/1696

Actions
Copy link
 #2

Updated by Mr. Hudson almost 13 years ago

Patch set 1 of change If068c3483225d4a21a69493a54ab2845c1f48760 has been pushed to the review server.
It is available at http://review.typo3.org/1697

Actions
Copy link
 #3

Updated by Alexander Stehlik almost 13 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF