Project

General

Profile

Actions
Copy link

Bug #25197

closed

PageRenderer remove comments lile copyright from js files

Added by Xaver Maierhofer over 13 years ago. Updated almost 10 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-02-28
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

if some js is added with page.includeJS.fileXY = path/file.js
maybe same thing with $pagerender = $GLOBALS['TSFE']->getPageRenderer();
$pagerender->addJsFile($file, $type = 'text/javascript', $compress = true, $forceOnTop = true, $allWrap = '');

(issue imported from #M17791)

Actions
Copy link
 #1

Updated by Xaver Maierhofer over 13 years ago

-lile +like

Actions
Copy link
 #2

Updated by Steffen Kamper over 13 years ago

what do you think is compress for?

Actions
Copy link
 #3

Updated by Xaver Maierhofer over 13 years ago

Compress of js is really nice, but what is about the copyright and license informations of js frameworks or lightboxe and other scripts. Often in min version on developer site is in front a comment like this:
/*!
  • Product XY
  • Copyright by .... 20XX
  • Licence MIT, GPL whatever
    */
Maybe let comments with /*! stay and remove comments witch start with /*
Actions
Copy link
 #4

Updated by Georg Ringer almost 10 years ago

  • Description updated (diff)
  • Status changed from New to Rejected
  • Target version deleted (0)
  • Is Regression set to No

as stated by Steffen: compression removes all comments. if you still need those for legal reasons, just collect all minified versions into one file and don't use the compression of the core.

no plans to change the compression algorithm.

Actions
Copy link

Also available in: Atom PDF