Feature #25320

Element browser should be more uniform in the parts tree, upload form and create folder form

Added by Tommy Juhnke almost 9 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-03-14
Due date:
% Done:

100%

PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

The element browser's presentation is not the same in the three parts

  • tree
  • upload form
  • create form

I suggest to change the presentation according to the following screenshots.

Just open the element browser in an image content element (by clicking on the folder icon)

The usability will be approved by

  • not displaying the "display thumbnails" option if no folder was selected
  • using the same paddings around the two lower upload & create folder forms
  • switching the "override existing files" checkbox and the submit button in upload form
  • adding a top/bottom padding to the "override existing files" checkbox
    (issue imported from #M17942)

screen-is.png View (63.2 KB) Administrator Admin, 2011-03-14 18:42

screen-should.png View (62 KB) Administrator Admin, 2011-03-14 18:42

25320_chrome.png View (30.3 KB) Lorenz Ulrich, 2011-04-29 16:45

25320_firefox.png View (30.8 KB) Lorenz Ulrich, 2011-04-29 16:45

25320_ie8.png View (26.3 KB) Lorenz Ulrich, 2011-04-29 16:45

Associated revisions

Revision ac41534b (diff)
Added by Tommy Juhnke over 8 years ago

[FEATURE] Streamline element browser in tree, upload & create folder form

This patch makes the element browser more conform in the three parts by
adding padding to the upload/create folder forms. And move the "display
thumbnails" checkbox to the top of the right tree navigation (right
below the bulk actions).

Furthermore, the three parts are visually splitted by a border which
made it necessary to add new id attributes to the both forms in order
to make them adressable in the stylesheets.

Resolves #25320

Change-Id: I80211a8ace933fe4c44002a5eeb504bfa3360439
Reviewed-on: http://review.typo3.org/1165
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

History

#2 Updated by Lorenz Ulrich over 8 years ago

Very nice catch - I always hated the look of the element browser. As soon as I can use port 29418 I will push another patch set. I removed the left 5px left margin of the headers and idented the file list by 10 pixels (as all other elements in the browser as idented 10px relative to the headers).

Additionally, I aligned the "Overwrite existing files" button, set a margin before the "Create folders" button and idented the thumbnails so that it makes more sense visually.

The three attached screenshot demonstrate that this works in Chrome/Firefox and IE8.

#3 Updated by Tommy Juhnke over 8 years ago

Hi Lorenz,

I've added a review for your patch set. Good work! Thank you very much, especially for your browser screenshots, I don't have the possibility to check in MSIE browsers here. ;)

#4 Updated by Tommy Juhnke over 8 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF