Bug #25374: Recursion error in typoscript when including typoscript files - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #25374

closed

Recursion error in typoscript when including typoscript files

Added by André Spindler about 13 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Tobias Liebig

Category:

Target version:

Start date:

2011-03-22

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

5.2

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

I switched templating on one of my installations.
So now there are 9 setup files for the template paths. I include the all in only one template record on root-level of the page tree.
And all works fine.

But then I install an additional extension and also I create the next typoscript file and add the definitions for this extension.
When I now open the typoscript editor for the setup field and enable the include of the file contents, the content of the last/10th file is overwritten with "### ERROR: Recursion!".
So I only can include 9 typoscript files.
If you don't care about this, the content if the file is deleted an page rendering is broken.

But there is no recursion in the files at all!
I include them all in the template record, no file is included by another!
And if I remove a file in the middle, the last file is loaded correct.

Also the extension t3editor is NOT installed, I use the default editor in tstemplate_info.

(issue imported from #M18012)

Files

recursion_error_in_typoscript.patch (880 Bytes) recursion_error_in_typoscript.patch

André Spindler, 2011-03-31 14:31

Actions

Copy link

Updated by André Spindler about 13 years ago

I now checked some code (class t3lib_tsparser):

When an opening include tag is foun in the typoscript code, the function "extractIncludes" is called its parameter "cycle_counter" is increased.
But it is not decreased then the correspondending end tag of the file include is found.
And this function stops working if the counter has reached a limit of 10.

The function "checkIncludeLines" is obviously used whewn rendering the page. This function also lacks the code to decrease the counter. But in this function the limit is set to 100.

Actions

Copy link

Updated by André Spindler about 13 years ago

Now I found the fix for this problem:

In "class.t3lib_tsparser.php" the line 729 (4.5.2) has to be modified:
Original:
$fileContentString = self::extractIncludes($fileContentString, ++$cycle_counter, $extractedFileNames);

Correct:
$fileContentString = self::extractIncludes($fileContentString, $cycle_counter + 1, $extractedFileNames);

So every time the function is called within the foreach loop all includes on the same level are called with the same recursion level. Without the patch this level is increased every time.

I told about the function "checkIncludeLines" before, which also uses this recursion, the line there looks like this:
$included_text = self::checkIncludeLines(t3lib_div::getUrl($filename), $cycle_counter + 1, $returnFiles);
You can see, there is no such problem... ;-)

Actions

Copy link

Updated by Tobias Liebig about 13 years ago

Assignee set to Tobias Liebig
Target version deleted (0)

Hej André,

thanks for digging into the issue.
Can you make a patch and push it to gerrit or send it to me?

Actions

Copy link

Updated by Tobias Liebig about 13 years ago

we're going to "offer" this on the planned "bug-auction" tonight (t3board11). I'll take care of this issue.

Actions

Copy link

Updated by Tobias Liebig about 13 years ago

Subject changed from Recursion error in tseditor when including typoscript files to Recursion error in typoscript when including typoscript files

Actions

Copy link