Project

General

Profile

Actions

Bug #25625

closed

Don't show rights check on Windows

Added by Francois Suter about 15 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Should have
Category:
scheduler
Target version:
-
Start date:
2009-10-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The test that checks whether the cli_dispatch script is executable always returns false on Windows. So it should not be displayed at all.

Reported by Ingmar Schlecht. Needs to be verified.

(issue imported from #M12251)


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #25616: Missing documentation for setting up cron jobs on WindowsClosedFrancois Suter2009-09-30

Actions
Actions #1

Updated by Steffen Kamper about 15 years ago

confirmed.

"The webserver user is not allowed execute this script."

which is obviously wrong.

Actions #2

Updated by Francois Suter about 15 years ago

Could a Windows user please test the attached patch? The result should be that the rights check doesn't show up anymore on Windows.

Note: the patch additionally contains a couple of initilisations cleanups, don't worry about them.

Actions #3

Updated by Steffen Kamper about 15 years ago

doesn't work here, $GLOBALS['TYPO3_OS'] is "null"

its a constant,, no globals so check:

if (TYPO3_OS !== 'WIN')

But then on windows nothing is outputted, i would expect OK message like with the BE_USER

Actions #4

Updated by Francois Suter about 15 years ago

Funnily enough, the test was taken from another sysext ;-)

I've uploaded a new version of the patch, could you test it again, please?

Actions #5

Updated by Steffen Kamper about 15 years ago

yeah, v2 works perfect. I'd say make a FYI, i will post vote.

With tsconfig_help i'll examine if rebuild really fails on win. Correcting the check disables it on Windows, so i have to be sure that it's done for a good reason ;)

Actions #6

Updated by Steffen Kamper about 15 years ago

i checked for tsconfig_help and patch can be found in core list, #12355

Actions #7

Updated by Francois Suter about 15 years ago

Committed to trunk in revision 6287

Actions #8

Updated by Michael Stucki almost 11 years ago

  • Category set to scheduler
Actions #9

Updated by Michael Stucki almost 11 years ago

  • Project changed from 739 to TYPO3 Core
  • Category changed from scheduler to scheduler
  • Target version deleted (0)
Actions

Also available in: Atom PDF