Bug #25979

Wrong type hinting in interface tslib_menu_filterMenuPagesHook

Added by Michael Birchler over 8 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2011-04-15
Due date:
% Done:

100%

TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

public function tslib_menu_filterMenuPagesHook (array &$data, array $banUidArray, $spacer, tslib_tmenu $obj)

$obj should hint for tslib_menu and not as wrongly specified tslib_tmenu.

If hook is used and for example a GMENU will be processed an exception will be thrown.

interface.tslib_menu_filterMenuPagesHook.php.diff View (747 Bytes) Michael Birchler, 2011-04-15 13:10

Associated revisions

Revision 47670f70 (diff)
Added by Michael Birchler over 8 years ago

[BUGFIX] Wrong type hinting in interface tslib_menu_filterMenuPagesHook

tslib_menu_filterMenuPagesHook::tslib_menu_filterMenuPagesHook expects a
tslib_tmenu object as fourth parameter $obj.
$obj should hint for tslib_menu and not as wrongly specified tslib_tmenu.
If hook is used and for example a GMENU will be processed an exception
will be thrown.

Change-Id: I0a61737755afbda6e2ab6c02ba59c078a77cc020
Resolves: #25979
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1649
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision ffc1a66a (diff)
Added by Michael Birchler over 8 years ago

[BUGFIX] Wrong type hinting in interface tslib_menu_filterMenuPagesHook

tslib_menu_filterMenuPagesHook::tslib_menu_filterMenuPagesHook expects a
tslib_tmenu object as fourth parameter $obj.
$obj should hint for tslib_menu and not as wrongly specified tslib_tmenu.
If hook is used and for example a GMENU will be processed an exception
will be thrown.

Change-Id: I0b9689f9ced9c027c1ef757ef37126268b568c97
Resolves: #25979
Reviewed-on: http://review.typo3.org/1680
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Revision 54f516e0 (diff)
Added by Michael Birchler over 8 years ago

[BUGFIX] Wrong type hinting in interface tslib_menu_filterMenuPagesHook

tslib_menu_filterMenuPagesHook::tslib_menu_filterMenuPagesHook expects a
tslib_tmenu object as fourth parameter $obj.
$obj should hint for tslib_menu and not as wrongly specified tslib_tmenu.
If hook is used and for example a GMENU will be processed an exception
will be thrown.

Change-Id: Iacab5c7f0098009303181316a98398e5f8ef6fe5
Resolves: #25979
Reviewed-on: http://review.typo3.org/1681
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

History

#1 Updated by Steffen Gebert over 8 years ago

Sounds reasonable! Michael, could you push your patch to the review system? See this tutorial

Thanks!
Steffen

#2 Updated by Mr. Hudson over 8 years ago

Patch set 1 of change I0a61737755afbda6e2ab6c02ba59c078a77cc020 has been pushed to the review server.
It is available at http://review.typo3.org/1649

#3 Updated by Mr. Hudson over 8 years ago

Patch set 2 of change I0a61737755afbda6e2ab6c02ba59c078a77cc020 has been pushed to the review server.
It is available at http://review.typo3.org/1649

#4 Updated by Michael Birchler over 8 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF