TYPO3 Core

Patch set 1 of change I1f5df4abe014e61ac463d5c12b9c240a6f2b7ccc has been pushed to the review server.
It is available at http://review.typo3.org/2509

Copy from http://forge.typo3.org/issues/25350:

I'm sorry, but I think the solution with Ext.urlEncode doesn't work.
From the ExtJs-manual: Takes an object and converts it to an encoded URL. e.g. Ext.urlEncode({foo: 1, bar: 2}); would return "foo=1&bar=2".
In jsfunc.tbe_editor.js the code
Ext.urlEncode({'' : output});
returns
=mystring if output=mystring.
Inserted in
<a onclick="...P[fieldChangeFuncHash]=afadea6d036792882b4ff362f4393c30244fa4cf'+'&P[currentValue]='+TBE_EDITOR.rawurlencode(document.editform['data[tt_content]⁷[header_link]_hr'].value,200)+'&P[currentSelectedValues]='+TBE_EDITOR.curSelected('data[tt_content]⁷[header_link]_hr_list')..." href="#"><img title="Link" alt="Link" src="sysext/t3skin/icons/gfx/link_popup.gif"></a> (created in t3lib_tceforms::renderWizard) the finally called URL for the popup is
http://.../typo3/browse_links.php?mode=wizard...&P[currentValue]==mystring&P[currentSelectedValues]=.
You see the == next to &P[currentValue]? The second = is part of the value and not necesarry. ;-)
I think, we have to possible solutions:
1. change all places in the TYPO3 core where TBE_EDITOR.rawurlencode is used to give Ext.urlEncode the correct object or
2. use encodeURIComponent(output) instead of Ext.urlEncode({'' : output}). encodeURIComponent is supported since IE5.5 and Netscape 6, so I don't think this would be a problem.

I would prever the second solution because with this solution we only have to change one little line. In my opinion using Ext.urlEncode is a breaking change.

What do you think?

https://review.typo3.org/#change,2509

Patch set 2 of change I1f5df4abe014e61ac463d5c12b9c240a6f2b7ccc has been pushed to the review server.
It is available at http://review.typo3.org/2509