Bug #27217
closedt3lib_div::cmpFQDN() lacks support for IPv6, direct hostnames and has matching-problems
100%
Description
Description of this function shows that it should compare a hostname with a list. What it did until now was take an IP-address (IPv4-only!), resolve that to a hostname itself and compare that.
Without breaking backward-compatibility this function can/needs to be extended to do what it's supposed to do (compare a given hostname with a list). When keeping IPv4-support and automatically reverse-resolve that, IPv6-support would also be good to have.
Comparing hostnames has matching-problems though. Giving it a host "www.typo3.org" and comparing that against "www" currently results in "true". According to the intended functionality the list-entry would need to be "www.*". It also currently doesn't support wildcard-matches at beginning or in the middle of a hostname, where * would resolve to an arbitrary number (>= 1) of hostname-parts.
Unittests for compares would also be great in this context.
Updated by Mr. Hudson over 13 years ago
Patch set 1 of change I721fb6d376ee9ef01352799dfad1813b38e87ded has been pushed to the review server.
It is available at http://review.typo3.org/2526
Updated by Mr. Hudson over 13 years ago
Patch set 2 of change I721fb6d376ee9ef01352799dfad1813b38e87ded has been pushed to the review server.
It is available at http://review.typo3.org/2526
Updated by Mr. Hudson over 13 years ago
Patch set 3 of change I721fb6d376ee9ef01352799dfad1813b38e87ded has been pushed to the review server.
It is available at http://review.typo3.org/2526
Updated by Mr. Hudson over 13 years ago
Patch set 4 of change I721fb6d376ee9ef01352799dfad1813b38e87ded has been pushed to the review server.
It is available at http://review.typo3.org/2526
Updated by Mr. Hudson over 13 years ago
Patch set 5 of change I721fb6d376ee9ef01352799dfad1813b38e87ded has been pushed to the review server.
It is available at http://review.typo3.org/2526
Updated by Mr. Hudson over 13 years ago
Patch set 1 of change I15328839d28746c68d7ef108b783c1ffe40d99cd has been pushed to the review server.
It is available at http://review.typo3.org/3924
Updated by Xavier Perseguers over 13 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset 0746cf9c9eb382d8d03b1cd2ae85a8110427411f.
Updated by Xavier Perseguers about 13 years ago
- Status changed from Resolved to Under Review
- Target version set to 4.6.0-beta2
- % Done changed from 100 to 0
Updated by Xavier Perseguers about 13 years ago
- Priority changed from Should have to Must have
Updated by Xavier Perseguers about 13 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Updated by Xavier Perseguers over 12 years ago
- Status changed from Resolved to Closed