Bug #27227

Bug #20473: Starttime/endtime is not taken into account when caching

Use Runtime Cache in tslib_fe::get_cache_timeout

Added by Steffen Gebert over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-06-05
Due date:
% Done:

100%

TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Thanks to #20473, start and stop times of records are now taken into account during a page's cache lifetime calculation.
To prevent repeated computations, the value is cached inside tslib_fe::get_cache_timeout, using a class variable getCacheTimeoutCache.

The Runtime Cache (#27208) not only offers a cleaner way to do so, it also provides a remedy against the currently existing problem that get_cache_timeout() does its job exactly twice: Once during menu generation (which seems to work with a cloned copy of TSFE) and once before putting the page contents into the cache. As both class instances share the runtime cache, the second calculation can be safed.


Related issues

Follows TYPO3 Core - Feature #27208: Add a runtime cache Closed 2011-06-04

Associated revisions

Revision fea7f6ec (diff)
Added by Steffen Gebert over 8 years ago

[BUGFIX] Use runtime cache in tslib_fe::get_cache_timeout

Thanks to #20473, start and stop times of records are now taken into
account during a page's cache lifetime calculation.
To prevent repeated computations, the value is cached inside
tslib_fe::get_cache_timeout(), using a class variable
getCacheTimeoutCache.

The Runtime Cache (#27208) not only offers a cleaner way to do so, it
also provides a remedy against the currently existing problem that
get_cache_timeout() does its job exactly twice: Once during menu
generation (which seems to work with a cloned copy of TSFE) and once
before putting the page contents into the cache. As both class instances
share the runtime cache, the second calculation can be safed.

Change-Id: I0b241749639a678ba6c1addd8d57e2256cf52bc2
Resolves: #27227
Depends: #27208
Reviewed-on: http://review.typo3.org/2531
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

History

#1 Updated by Mr. Hudson over 8 years ago

Patch set 1 of change I0b241749639a678ba6c1addd8d57e2256cf52bc2 has been pushed to the review server.
It is available at http://review.typo3.org/2531

#2 Updated by Mr. Hudson over 8 years ago

Patch set 2 of change I0b241749639a678ba6c1addd8d57e2256cf52bc2 has been pushed to the review server.
It is available at http://review.typo3.org/2531

#3 Updated by Steffen Gebert over 8 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#4 Updated by Steffen Gebert over 8 years ago

  • Target version set to 1281

#5 Updated by Xavier Perseguers almost 8 years ago

  • Status changed from Resolved to Closed

#6 Updated by Ernesto Baschny over 6 years ago

  • Target version deleted (1281)

Also available in: Atom PDF