Project

General

Profile

Actions

Bug #29167

closed

RTE: External links not updated to internal by link dialogue

Added by Alexander Grein about 13 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
Start date:
2011-08-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Links to internal pages, set by htmlarea, will be converted to external links after saving.
All these links open in a blank window. realurl does not transform them correctly.

Tested with google chrome 13 and TYPO3 4.5.5

Actions #1

Updated by Chris topher about 13 years ago

  • Subject changed from links to internal pages set by htmlarea will be converted to external link after saving to rtehtmlarea: Links to internal pages will be converted to external links after saving
  • Category set to RTE (rtehtmlarea + ckeditor)
  • Status changed from New to Needs Feedback

Please check how the link to the internal page looks like in your database.

And check how the link looks like when you view the sourcecode of your website in the frontend.

Actions #2

Updated by Alexander Grein about 13 years ago

The link inside the database (bodytext column) looks like this:
<link http://www.biberkor.t3wa.de/?id=182 - internal-link>Oberstufe > Aufnahme.</link>

The Link in the sourcecode of the website looks like:
<a href="http://www.biberkor.t3wa.de/?id=182&quot; target="_blank" class="internal-link">Oberstufe > Aufnahme.</a>

But i choose an internal page inside the rtehtmlarea link popup.

Actions #3

Updated by Stanislas Rolland about 13 years ago

Alexander Grein wrote:

The link inside the database (bodytext column) looks like this:
<link http://www.biberkor.t3wa.de/?id=182 - internal-link>Oberstufe > Aufnahme.</link>

This is not normal.

Should be <link 182 - internal-link>Oberstufe > Aufnahme.</link>

Under what domain did you login into the BE?

Actions #4

Updated by Alexander Grein about 13 years ago

The domain is http://www.biberkor.t3wa.de/typo3

But i think i found the problem:
The content was overtaken of an other CMS (Joomla btw ;-) ) by copy and paste.
So, als links became external first.

During revising the content in TYPO3, all this (former) internal links were converted to (TYPO3) internal links by hand, using the link wizard in the RTE.
But instead of deleting a link first and set them new, we just changed the type from "External URL" to "Page" (internal) choose the propper page in the pagetree and clicked "Update".

Now comes the problem:
All (former) internal links, which automatically got the RTE-Attribute "external="1"" after pasting it in the RTE, still have this attribute after changing the link type to "Page".
If i delete this attribute by hand, the link will be generated correctly.

Actions #5

Updated by Stanislas Rolland about 13 years ago

  • Subject changed from rtehtmlarea: Links to internal pages will be converted to external links after saving to RTE: External links not updated to internal link by link dialogue
  • Assignee set to Stanislas Rolland
Actions #6

Updated by Stanislas Rolland about 13 years ago

  • Subject changed from RTE: External links not updated to internal link by link dialogue to RTE: External links not updated to internal by link dialogue
Actions #7

Updated by Mr. Hudson about 13 years ago

Patch set 1 of change Ica76a8d862fd2547ad0baac55b3770dc2cedf79a has been pushed to the review server.
It is available at http://review.typo3.org/4769

Actions #8

Updated by Mr. Hudson about 13 years ago

Patch set 1 of change I94762da2fe19cf2cf91f6af755234347aef942ab has been pushed to the review server.
It is available at http://review.typo3.org/4773

Actions #9

Updated by Stanislas Rolland about 13 years ago

Please test this patch: http://review.typo3.org/4773

Actions #10

Updated by Stanislas Rolland about 13 years ago

  • Status changed from Needs Feedback to Under Review
Actions #11

Updated by Stanislas Rolland about 13 years ago

Stanislas Rolland wrote:

Please test this patch: http://review.typo3.org/4773

Please confirm that this patch fixes the issue.

Actions #12

Updated by Stanislas Rolland about 13 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF