TYPO3 Core

Patch set 1 of change Icb2789e9ad3c56b65d098fe136d898954e39a51c has been pushed to the review server.
It is available at http://review.typo3.org/4718

Patch set 2 of change Icb2789e9ad3c56b65d098fe136d898954e39a51c has been pushed to the review server.
It is available at http://review.typo3.org/4718

When creating a wizard for new CE, typical code (including support of TYPO3 versions older than 4.6) looks as follows:

/**
 * Reads the extension locallang.xml and returns the $LOCAL_LANG array found in that file.
 *
 * @return array The array with language labels
 */
protected function includeLocalLang() {
    $version = class_exists('t3lib_utility_VersionNumber')
            ? t3lib_utility_VersionNumber::convertVersionNumberToInteger(TYPO3_version)
            : t3lib_div::int_from_ver(TYPO3_version);
    if ($version < 4006000) {
        $llFile = t3lib_extMgm::extPath('egovapi') . 'Resources/Private/Language/locallang.xml';
        $LOCAL_LANG = t3lib_div::readLLXMLfile($llFile, $GLOBALS['LANG']->lang);
    } else {
        $llFile = t3lib_extMgm::extPath('egovapi') . 'Resources/Private/Language/locallang.xlf';
        /** @var $factory t3lib_l10n_Factory */
        $factory = t3lib_div::makeInstance('t3lib_l10n_Factory');
        $LOCAL_LANG = $factory->getParsedData($llFile, $GLOBALS['LANG']->lang, '', 1);
    }

    return $LOCAL_LANG;
}

However the call to

$LOCAL_LANG = $factory->getParsedData($llFile, $GLOBALS['LANG']->lang, '', 1);

(where "1" stands for the errorMode "do nothing when file was not found") returns the English version of the labels if no translation is found for $GLOBALS['LANG']->lang.

It should fall back properly using the language dependency as well.

After debugging this problem and thinking more about it, there is no need to further change the proposed patch.

Here is how a CE wizard should be updated to properly work with language dependencies:

/**
 * Reads the extension locallang.xml and returns the $LOCAL_LANG array found in that file.
 *
 * @return array The array with language labels
 */
protected function includeLocalLang() {
    $version = class_exists('t3lib_utility_VersionNumber')
            ? t3lib_utility_VersionNumber::convertVersionNumberToInteger(TYPO3_version)
            : t3lib_div::int_from_ver(TYPO3_version);
    if ($version < 4006000) {
        $llFile = t3lib_extMgm::extPath('egovapi') . 'Resources/Private/Language/locallang.xml';
    } else {
        $llFile = t3lib_extMgm::extPath('egovapi') . 'Resources/Private/Language/locallang.xlf';
    }

    return $GLOBALS['LANG']->includeLLFile($llFile, FALSE);
}

Patch set 3 of change Icb2789e9ad3c56b65d098fe136d898954e39a51c has been pushed to the review server.
It is available at http://review.typo3.org/4718