Bug #29674

If ENABLE_INSTALL_TOOL can't be deleted access to Install Tool is not blocked

Added by Jigal van Hemert almost 11 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2011-09-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

For another test I made the ENABLE_INSTALL_TOOL file read only. When it was older than an hour it was attempted to remove it. The Install Tool outputs an ugly PHP warning that unlink() failed because permission was denied:

Warning: unlink(D:/webserver/xampp/htdocs/typo3conf/ENABLE_INSTALL_TOOL) [function.unlink]: Permission denied in D:\webserver\xampp\htdocs\typo3_src\typo3\install\index.php on line 66

But it is still possible to log in in the Install Tool and use all the options.

#1

Updated by Lucas Jenß almost 11 years ago

This commit fixes the bug :)

#2

Updated by Lucas Jenß almost 11 years ago

Tried to add the commit in Gerrit: https://review.typo3.org/#change,4906

#3

Updated by Mr. Hudson almost 11 years ago

Patch set 2 of change I78e1990b6a0b66ef8804ede9bbfa3546b08d4067 has been pushed to the review server.
It is available at http://review.typo3.org/4906

#4

Updated by Mr. Hudson almost 11 years ago

  • Status changed from New to Under Review

Patch set 3 of change I78e1990b6a0b66ef8804ede9bbfa3546b08d4067 has been pushed to the review server.
It is available at http://review.typo3.org/4906

#5

Updated by Mr. Hudson almost 11 years ago

Patch set 4 of change I78e1990b6a0b66ef8804ede9bbfa3546b08d4067 has been pushed to the review server.
It is available at http://review.typo3.org/4906

#6

Updated by Mr. Hudson almost 11 years ago

Patch set 5 of change I78e1990b6a0b66ef8804ede9bbfa3546b08d4067 has been pushed to the review server.
It is available at http://review.typo3.org/4906

#7

Updated by Mr. Hudson almost 11 years ago

Patch set 1 of change I14e7f453d72d13410246df00c8d8237d7fa3517f has been pushed to the review server.
It is available at http://review.typo3.org/6355

#8

Updated by Mr. Hudson almost 11 years ago

Patch set 1 of change I9804e2c6455768699a8b2ad11be4854bd3e359c6 has been pushed to the review server.
It is available at http://review.typo3.org/6356

#9

Updated by Lucas Jenß almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#10

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF