Project

General

Profile

Actions
Copy link

Bug #29782

closed

RTE marks email links as extern when there is an external link before the email link

Added by Roland Hager over 12 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Stanislas Rolland
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
4.4.12
Start date:
2011-09-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I guess the subject is self explanatory. The problem is always reproducible.

Our TYPO3 version: 4.4.10
rtehtmlarea version: 2.0.9

Example:

Switch the textmode on (do not disable the RTE) and paste the following HTML-code. You have to set the href for the internal link according to your site.

    <p><a href="http://typo3.org/">EXTERNAL-TEST-URL</a></p>
    <p><a href="mailto:NOT_OK@domain.com">email link NOT OK</a></p>

    <p><a href="http://YOUR.DOMAIN.HERE/?id=2">INTERNAL-TEST-URL</a></p>
    <p><a href="mailto:OK@domain.com">email link OK</a></p>

This will result in:

    <p><a external="1" href="http://typo3.org/">EXTERNAL-TEST-URL</a></p>
    <p><a external="1" href="mailto:NOT_OK@domain.com">email link NOT OK</a></p>

    <p><a href="http://YOUR.DOMAIN.HERE/?id=2">INTERNAL-TEST-URL</a></p>
    <p><a href="mailto:OK@domain.com">email link OK</a></p>

When you disable the RTE after inserting the above you'll find the email links marked as external looking as follows (the mailto: should not be there!):

  <link mailto:NOT_OK@domain.com>email link NOT OK</link>

Strange but true, if you add an internal link, the following email links are recognized just fine as demonstrated by the example.

As a quick work around I added the following to my RTE pageTS-Config:

  RTE.default.proc{
    entryHTMLparser_db = 1
    entryHTMLparser_db {
       tags {
        a{
            allowedAttribs = href,class
            }
      }
    }
  }

The RTE still adds external="1" attributes to email links but they will be filtered before the changes are written to the database and thus "mailto:" will not be handled as the protocol for that link.

Actions
Copy link
 #1

Updated by Alexander Grein over 12 years ago

May be the same problem already described in this issue (already fixed in 4.5.6):
http://forge.typo3.org/issues/29167

Actions
Copy link
 #2

Updated by Stanislas Rolland over 12 years ago

Alexander Grein wrote:

May be the same problem already described in this issue (already fixed in 4.5.6):
http://forge.typo3.org/issues/29167

I don't think so.

The problem arises after saving. This is a problem of the RTE transformation on the way to the database. The mailto link is incorrectly transformed.

Actions
Copy link
 #3

Updated by Stanislas Rolland over 12 years ago

  • Status changed from New to Accepted
Actions
Copy link
 #4

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change I38116e59f012ae6d552a5dd89fd371ea1a038794 has been pushed to the review server.
It is available at http://review.typo3.org/5514

Actions
Copy link
 #5

Updated by Stanislas Rolland over 12 years ago

  • Status changed from Accepted to Under Review
  • Assignee set to Stanislas Rolland
  • Target version set to 4.4.12
  • PHP Version set to 5.3
Actions
Copy link
 #6

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change I182cd969ea5768354981e83e7c2eaa6085a05cd1 has been pushed to the review server.
It is available at http://review.typo3.org/5515

Actions
Copy link
 #7

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change I3a9fa56810802abe47c37a693b8601c2d3ceed2f has been pushed to the review server.
It is available at http://review.typo3.org/5516

Actions
Copy link
 #8

Updated by Stanislas Rolland over 12 years ago

Please test this change: http://review.typo3.org/5540

Actions
Copy link
 #9

Updated by Mr. Hudson over 12 years ago

Patch set 2 of change I38116e59f012ae6d552a5dd89fd371ea1a038794 has been pushed to the review server.
It is available at http://review.typo3.org/5514

Actions
Copy link
 #10

Updated by Mr. Hudson over 12 years ago

Patch set 3 of change I38116e59f012ae6d552a5dd89fd371ea1a038794 has been pushed to the review server.
It is available at http://review.typo3.org/5514

Actions
Copy link
 #11

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change I38751c6c5eb56920eb1286f2d39393b3dae7ce34 has been pushed to the review server.
It is available at http://review.typo3.org/5537

Actions
Copy link
 #12

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change If83c2c8b04def953cbc95f617a14111e7641a867 has been pushed to the review server.
It is available at http://review.typo3.org/5539

Actions
Copy link
 #13

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change Iefc0d8368c9b33cb24c701e2277f888104afe7d1 has been pushed to the review server.
It is available at http://review.typo3.org/5540

Actions
Copy link
 #14

Updated by Stanislas Rolland over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #15

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF