Bug #30636

TCA: subtypes_addlist not being processed if the subtype_value_field is in a palette

Added by Ernesto Baschny almost 7 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
Start date:
2011-10-07
Due date:
% Done:

100%

TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

How to reproduce:

Install mc_googlesitemap in TYPO3 4.5 and wonder where the referred fields from the documentation are: they are not rendered. They are supposed to appear in the content element of type "Menu/Sitemap" when you choose one of the newly introduced Subtypes "Sitemaps for Contents" or "Sitemaps for Pages".

Bug in action (extension mc_googlesitemap)

Background:

Extensions can add fields to an existing table depending on a certain "subtype". E.g. Content Element of type "menu" has subtype stored in "menu_type". Extension mc_googlesitemap wants to add fields depending on the menu_type:

$TCA["tt_content"]["types"]["menu"]["subtype_value_field"]="menu_type";
$TCA["tt_content"]["types"]["menu"]["subtypes_addlist"][$_EXTKEY."_pi1"]= ...

This used to work fine since 4.4, but in 4.5 the "menu_type" field is now inside a palette, so the new fields have no place to be positioned and so they are not rendered at all.

Solution:

Go through the palettes too, and add the new fields right after the palette where the field resides in. Now it looks like this:

How it looks with the proposed fix

subtype_addlist-bug.png View - Bug in action (extension mc_googlesitemap) (8.96 KB) Ernesto Baschny, 2011-10-07 17:32

subtype_addlist-correct.png View - How it looks with the proposed fix (15.3 KB) Ernesto Baschny, 2011-10-07 17:32

Associated revisions

Revision 752a963a (diff)
Added by Benni Mack almost 5 years ago

[BUGFIX] TCA: subtypes_addlist not processed

TCA: subtypes_addlist is not processed
if the subtype_value_field is in a palette

Fixes: #30636
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I6bcaaf36c330962c1d7d9fdd4a73ae502e9710dc
Reviewed-on: https://review.typo3.org/9549
Reviewed-by: Wouter Wolters
Tested-by: Lucas Bremgartner
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

Revision 87b18bfd (diff)
Added by Benni Mack almost 5 years ago

[BUGFIX] TCA: subtypes_addlist not processed

TCA: subtypes_addlist is not processed
if the subtype_value_field is in a palette

Fixes: #30636
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I6bcaaf36c330962c1d7d9fdd4a73ae502e9710dc
Reviewed-on: https://review.typo3.org/23159
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

Revision fbbad86c (diff)
Added by Benni Mack almost 5 years ago

[BUGFIX] TCA: subtypes_addlist not processed

TCA: subtypes_addlist is not processed
if the subtype_value_field is in a palette

Fixes: #30636
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I6bcaaf36c330962c1d7d9fdd4a73ae502e9710dc
Reviewed-on: https://review.typo3.org/23160
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

Revision 9f987b9e (diff)
Added by Ernesto Baschny almost 5 years ago

[BUGFIX] TCA: subtypes_addlist not processed

TCA: subtypes_addlist is not processed
if the subtype_value_field is in a palette

Change-Id: I6bcaaf36c330962c1d7d9fdd4a73ae502e9710dc
Fixes: #30636
Releases: 4.5, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/23161
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

Revision 4571ca9c (diff)
Added by Ernesto Baschny almost 5 years ago

[BUGFIX] TCA: subtypes_addlist not processed

TCA: subtypes_addlist is not processed
if the subtype_value_field is in a palette

Change-Id: I6bcaaf36c330962c1d7d9fdd4a73ae502e9710dc
Fixes: #30636
Releases: 4.5, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/19652
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

History

#1 Updated by Mr. Hudson almost 7 years ago

Patch set 1 of change Ie9147db223530a7523cc67cdf5c3bdd218d51a2a has been pushed to the review server.
It is available at http://review.typo3.org/5618

#2 Updated by Chris topher over 6 years ago

  • Target version changed from 4.5.7 to 4.5.8

#3 Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/5618

#4 Updated by Ernesto Baschny over 6 years ago

  • Target version changed from 4.5.8 to 4.5.12

#5 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9549

#6 Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19652

#7 Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19653

#8 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/9549

#9 Updated by Gerrit Code Review about 5 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/9549

#10 Updated by Gerrit Code Review almost 5 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/9549

#11 Updated by Ernesto Baschny almost 5 years ago

  • Target version changed from 4.5.12 to next-patchlevel

#12 Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23159

#13 Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23160

#14 Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/23161

#15 Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19652

#16 Updated by Ernesto Baschny almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF