Project

General

Profile

Actions

Bug #30636

closed

TCA: subtypes_addlist not being processed if the subtype_value_field is in a palette

Added by Ernesto Baschny over 12 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
Start date:
2011-10-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

How to reproduce:

Install mc_googlesitemap in TYPO3 4.5 and wonder where the referred fields from the documentation are: they are not rendered. They are supposed to appear in the content element of type "Menu/Sitemap" when you choose one of the newly introduced Subtypes "Sitemaps for Contents" or "Sitemaps for Pages".

Bug in action (extension mc_googlesitemap)

Background:

Extensions can add fields to an existing table depending on a certain "subtype". E.g. Content Element of type "menu" has subtype stored in "menu_type". Extension mc_googlesitemap wants to add fields depending on the menu_type:

$TCA["tt_content"]["types"]["menu"]["subtype_value_field"]="menu_type";
$TCA["tt_content"]["types"]["menu"]["subtypes_addlist"][$_EXTKEY."_pi1"]= ...

This used to work fine since 4.4, but in 4.5 the "menu_type" field is now inside a palette, so the new fields have no place to be positioned and so they are not rendered at all.

Solution:

Go through the palettes too, and add the new fields right after the palette where the field resides in. Now it looks like this:

How it looks with the proposed fix


Files

subtype_addlist-bug.png (8.96 KB) subtype_addlist-bug.png Bug in action (extension mc_googlesitemap) Ernesto Baschny, 2011-10-07 17:32
subtype_addlist-correct.png (15.3 KB) subtype_addlist-correct.png How it looks with the proposed fix Ernesto Baschny, 2011-10-07 17:32
Actions #1

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change Ie9147db223530a7523cc67cdf5c3bdd218d51a2a has been pushed to the review server.
It is available at http://review.typo3.org/5618

Actions #2

Updated by Chris topher over 12 years ago

  • Target version changed from 4.5.7 to 4.5.8
Actions #3

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/5618

Actions #4

Updated by Ernesto Baschny over 12 years ago

  • Target version changed from 4.5.8 to 4.5.12
Actions #5

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9549

Actions #6

Updated by Gerrit Code Review about 11 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19652

Actions #7

Updated by Gerrit Code Review about 11 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19653

Actions #8

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/9549

Actions #9

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/9549

Actions #10

Updated by Gerrit Code Review almost 11 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/9549

Actions #11

Updated by Ernesto Baschny almost 11 years ago

  • Target version changed from 4.5.12 to next-patchlevel
Actions #12

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23159

Actions #13

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23160

Actions #14

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/23161

Actions #15

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19652

Actions #16

Updated by Ernesto Baschny almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #17

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF