Task #32136
closedReports module has knowledge about internal data of salted passwords
100%
Description
Reports module changes from issue #30695 introduced a check for the saltedpasswords extension and a report about users, whose passwords are not protected by the saltedpasswords.
The problem with that solution is that reports uses an internal knowledge from saltedpasswords extension: a password prefix. This is bad because:- it is a "solution spread" across modules
- details on the password encodings should be known only to the saltedpasswords extension to ensure that new methods can be added and only that extension handles it
The fix is to remove the query from the Reports module but call a newly introduced method in the saltedpasswords to get that number of users.
Updated by Mr. Jenkins about 13 years ago
- Status changed from New to Under Review
Patch set 1 of change Iec27610c2227ed15537f37b53e1b26443b5a276f has been pushed to the review server.
It is available at http://review.typo3.org/6953
Updated by Mr. Jenkins about 13 years ago
Patch set 2 of change Iec27610c2227ed15537f37b53e1b26443b5a276f has been pushed to the review server.
It is available at http://review.typo3.org/6953
Updated by Gerrit Code Review about 13 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6953
Updated by Dmitry Dulepov almost 13 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 08c684f03f2b6f86829a32f0df70a1d63581feb9.
Updated by Gerrit Code Review almost 13 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/7407
Updated by Gerrit Code Review almost 13 years ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/7408
Updated by Dmitry Dulepov almost 13 years ago
- Status changed from Under Review to Resolved
Applied in changeset 329f00d4da99d5848dfd4ff65eea59be2dcbefc1.