Bug #33633
closed
SwiftMailerAdapter doesn't handle Content-Transfer-Encoding correctly
0%
Description
If there's a Content-Transfer-Encoding header set in the incoming mail, the adapter class sets that header for the SwiftMailer message, but doesn't change the encoder of the message. Thus it always uses the default encoder (quoted printable), which causes messed up messages when the mail that gets handed into the adapter is encoded differently. Strictly, the bug is in SwiftMailer, because it allows messing with the Content-Transfer-Encoding header without observing it to change the encoder accordingly. But for the time being, I guess the adapter should learn to just special case that header and do the encoder update itself.
I'll submit a patch for review tomorrow.
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8838
Updated by Gerrit Code Review over 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8838
Updated by Gerrit Code Review over 12 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8838
Updated by Gerrit Code Review over 12 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8838
Updated by Gerrit Code Review about 12 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8838
Updated by Gerrit Code Review about 12 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8838
Updated by Quadronet no-lastname-given over 11 years ago
Hello Gerrit, i use this patch, but i doesn´t work correctly. We send an html-newsletter to 8000 clients and some client become the newsletter in this form:
Subject: Aktuelle
Stellenanzeigen
Message-ID:
<1345952743.50399be743fbe@swif
t.generated>
Date: Sun, 26 Aug 2012
05:45:43 +0200
From: Kuehn Personalberatung
<kuehn@kuehngmbh.de>
Reply-To: Andreas
=?utf-8?Q?K=C3=BChn?= GmbH -
Newsletter
<kuehn@kuehngmbh.de>
MIME-Version: 1.0
Content-Type:
multipart/alternative;
boundary="_=_swift_v4_13459527
4350399be745781_=_"
Organization: Andreas
=?utf-8?Q?K=C3=BChn?= GmbH -
Newsletter
X-Priority: 3 (Normal)
X-TYPO3MID:
MID257_t1701-d73f95a4283d93d6d
5542799f6c0de25
X-Mailer: TYPO3
X-Info: valid message
X-Info: original Date
X-GMX-Antivirus: 0 (no virus
found)
X-GMX-Antispam: 0 (Sender is
in whitelist:
kuehn@kuehngmbh.de);
Detail=5D7Q89H36p4L00VTXC6D4q0
N+AH0PUCnIm2FNArnxesda4dwFTHxM
utaJaCPkPHLJYw9g
UI/h3KJFm5+2oqD8w==V1;
--_=_swift_v4_134595274350399b
e745781_=_
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding:
quoted-printable
--_=_swift_v4_134595274350399b
e745781_=_
Content-Type:
multipart/related;
boundary="_=_swift_v4_13459527
4350399be7470d6_=_"
--_=_swift_v4_134595274350399b
e7470d6_=_
Content-Type: text/html;
charset=utf-8
Content-Transfer-Encoding:
quoted-printable
<!DOCTYPE html PUBLIC
"-//W3C//DTD HTML 4.0
Transitional//EN" "http://ww=
w.w3.org/TR/REC-html40/loose.d
td">
<html>
<head><meta http-equiv=
=3D"Content-Type"
content=3D"text/html;
charset=3Dutf-8" /></head>
<bo= dy style=3D"margin:0;
padding:0;
text-align:center;
font=
-family:Arial, Helvetica,
sans-serif;
font-size:75.00%;
what´s this? You have an solution?
Best regard´s
Updated by Jigal van Hemert about 11 years ago
- Status changed from Under Review to Rejected
The SwiftMailerAdapter will be deprecated in TYPO3 CMS 6.1. It was only meant as a temporary solution to send most mails from old API calls using SwiftMailer until the extensions use the new mail API.
The extension should by now use the new mail API.
No effort will be made to improve the SwiftMailerAdapter or to add functionality.