Feature #34098

Group excludefields by table

Added by Joh. Feustel almost 8 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-02-19
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Currently the excludefield selector displays the table name and field name in field label. Its sometimes hard to scroll to the specific table and fiend fields.

Do not display table name redundantly for each item but group items like
it is done for other fields like page types.

  • Add header for each table of items in excludefields and remove table from item label
  • Add possibility to set icon for headers
  • Unset icon for page type headers
  • Remove unused variable $descr

See before after screenshots

before.jpg View (96.4 KB) Joh. Feustel, 2012-02-19 17:25

after.jpg View (89.3 KB) Joh. Feustel, 2012-02-19 17:25

groupExcludefields.diff View (3.39 KB) Joh. Feustel, 2012-02-19 17:25


Related issues

Related to TYPO3 Core - Bug #47839: Incorrect grouping of exclude fields in translated backend Closed 2013-05-02

Associated revisions

Revision 729efc20 (diff)
Added by Joh. Feustel almost 8 years ago

[TASK] Group excludefields by table

Do not display table name redundantly for each item but group items like
it is done for other fields like page types.

  • Add header for each table of items in excludefields array and remove
    table from item label
  • Add possibility to set icon for headers
  • Unset icon for page type headers
  • Remove unused variable $descr

Change-Id: I2115f154ee61c00dbe5af0fc45391bae9170ce16
Resolves: #34098
Releases: 4.7,4.6,4.5
Reviewed-on: http://review.typo3.org/9108
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Soren Malling
Tested-by: Soren Malling
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

Revision 399737c8 (diff)
Added by Joh. Feustel over 7 years ago

[TASK] Group excludefields by table

Do not display table name redundantly for each item but group items like
it is done for other fields like page types.

  • Add header for each table of items in excludefields array and remove
    table from item label
  • Add possibility to set icon for headers
  • Unset icon for page type headers
  • Remove unused variable $descr

Change-Id: I4201c64a50ee63c9d9e3415e0e8245614db7af07
Resolves: #34098
Releases: 4.7,4.6,4.5
Reviewed-on: http://review.typo3.org/13916
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Revision 7199e5da (diff)
Added by Joh. Feustel about 7 years ago

[TASK] Group excludefields by table

Do not display table name redundantly for each item but group items like
it is done for other fields like page types.

  • Add header for each table of items in excludefields array and remove
    table from item label
  • Add possibility to set icon for headers
  • Unset icon for page type headers
  • Remove unused variable $descr

Change-Id: Ic1abe4ed0032b5e2c0a04814f1371a9d1a84448e
Resolves: #34098
Releases: 4.7,4.6,4.5
Reviewed-on: http://review.typo3.org/13919
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Revision 723b023e (diff)
Added by Philipp Gampe almost 7 years ago

[BUGFIX] Incorrect grouping of exclude fields in translated backend

If you use the backend in a language other than English, then the
grouping of the exclude fields in the be_group record is messed up when
flexform fields are included.

E.g. in a German backend, all tt_content fields are grouped below pages.

Sort the table names beforehand and afterwards all fields inside each
table.
Besides the patch converts some variables names into meaningful ones.

Fixes: #47839
Related: #34098
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I28ebc69d5cfc0316bdf44558276d3e939d011c2d
Reviewed-on: https://review.typo3.org/20427
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Revision f49e4289 (diff)
Added by Philipp Gampe almost 7 years ago

[BUGFIX] Incorrect grouping of exclude fields in translated backend

If you use the backend in a language other than English, then the
grouping of the exclude fields in the be_group record is messed up when
flexform fields are included.

E.g. in a German backend, all tt_content fields are grouped below pages.

Sort the table names beforehand and afterwards all fields inside each
table.
Besides the patch converts some variables names into meaningful ones.

Fixes: #47839
Related: #34098
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I28ebc69d5cfc0316bdf44558276d3e939d011c2d
Reviewed-on: https://review.typo3.org/20506
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Revision 5bdc467b (diff)
Added by Philipp Gampe over 6 years ago

[BUGFIX] Incorrect grouping of exclude fields in translated backend

If you use the backend in a language other than English, then the
grouping of the exclude fields in the be_group record is messed up when
flexform fields are included.

E.g. in a German backend, all tt_content fields are grouped below pages.

Sort the table names beforehand and afterwards all fields inside each
table.
Besides the patch converts some variables names into meaningful ones.

Fixes: #47839
Related: #34098
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I28ebc69d5cfc0316bdf44558276d3e939d011c2d
Reviewed-on: https://review.typo3.org/20507
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Revision 6d80c93b (diff)
Added by Jigal van Hemert over 6 years ago

[BUGFIX] Incorrect grouping of exclude fields in translated backend

If you use the backend in a language other than English, then the
grouping of the exclude fields in the be_group record is messed up when
flexform fields are included.

E.g. in a German backend, all tt_content fields are grouped below pages.

Sort the table names beforehand and afterwards all fields inside each
table.
Besides the patch converts some variables names into meaningful ones.

Fixes: #47839
Related: #34098
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I28ebc69d5cfc0316bdf44558276d3e939d011c2d
Reviewed-on: https://review.typo3.org/20523
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Revision 0a8c9ddb (diff)
Added by Jigal van Hemert over 6 years ago

[BUGFIX] Incorrect grouping of exclude fields in translated backend

If you use the backend in a language other than English, then the
grouping of the exclude fields in the be_group record is messed up when
flexform fields are included.

E.g. in a German backend, all tt_content fields are grouped below pages.

Sort the table names beforehand and afterwards all fields inside each
table.
Besides the patch converts some variables names into meaningful ones.

For TYPO3_4-5, the patch merges the existing unit test into this file.

Change-Id: I28ebc69d5cfc0316bdf44558276d3e939d011c2d
Fixes: #47839
Related: #34098
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21636
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

History

#1 Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9108

#2 Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9108

#3 Updated by Joh. Feustel almost 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review over 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13916

#5 Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/13919

#6 Updated by Joh. Feustel over 7 years ago

  • Status changed from Under Review to Resolved

#7 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF