Bug #34156

No-Admin can’t delete FE-User from Recycler

Added by Mario Näther over 7 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-02-21
Due date:
% Done:

100%

TYPO3 Version:
4.5
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I delete an FE-user as no-Admin from normal BE list module and the fe-user moves to Recycler.
If I delete this fe-user from recycler as no-Admin, the recycler quest me "realy delete?" Yes or No? and I clicked on "Yes" and nothing happened, the fe-user already exists!

The SQLDebug of ExtJS request outputed:

SELECT * FROM fe_users WHERE uid=3877553 AND fe_users.deleted=0

But the deleted flag was already set to 1 from deletion on list module

I can reproduce this on TYPO3 4.5.11 and TYPO 4.6.4

TSConfig Settings for recycler

mod.recycler.allowDelete = 1

The attached patch file (from T3 4.6), fixed this on my TYPO3.

0001-test.patch View (1.02 KB) Mario Näther, 2012-02-21 18:18

0002-test.patch View (998 Bytes) Mario Näther, 2012-02-27 19:52

Associated revisions

Revision c7bdad7b (diff)
Added by Sascha Egerer over 6 years ago

[BUGFIX] Allow non-Admins to delete Records finally

This patch adds the posibility for non Admins to delete
records finally in the recycler.

Change-Id: I1fda11d621403758f4d78b7fa8f730d7b47d79a7
Fixes: #34156
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/10480
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision 05c3b7b5 (diff)
Added by Sascha Egerer over 6 years ago

[BUGFIX] Allow non-Admins to delete Records finally

This patch adds the posibility for non Admins to delete
records finally in the recycler.

Change-Id: I1fda11d621403758f4d78b7fa8f730d7b47d79a7
Fixes: #34156
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21453
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision 55eb3f88 (diff)
Added by Sascha Egerer over 6 years ago

[BUGFIX] Allow non-Admins to delete Records finally

This patch adds the posibility for non Admins to delete
records finally in the recycler.

Change-Id: I1fda11d621403758f4d78b7fa8f730d7b47d79a7
Fixes: #34156
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21454
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision e552a000 (diff)
Added by Sascha Egerer over 6 years ago

[BUGFIX] Allow non-Admins to delete Records finally

This patch adds the posibility for non Admins to delete
records finally in the recycler.

Change-Id: I1fda11d621403758f4d78b7fa8f730d7b47d79a7
Fixes: #34156
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21456
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

History

#1 Updated by Stefan Galinski over 7 years ago

Thanks for your report! Please open a new review request for your patch.

http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

#2 Updated by Mario Näther over 7 years ago

Here is a new patch file for 4.6. With this you can delete and undelete records from recycle.

Sorry but I can't open an review request, because I can't connect my TortoiseGit to Gerrit. I will added the Git Hook and the GitBash says "Permission denied (publickey)." ... do you have any solutions for me?

#3 Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10480

#4 Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10480

#5 Updated by Gerrit Code Review almost 7 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10480

#6 Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/10480

#7 Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/10480

#8 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/21453

#9 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/21454

#10 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/21455

#11 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/21456

#12 Updated by Sascha Egerer over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#13 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF